Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of Laravel's services.php #6

Merged
merged 1 commit into from Nov 18, 2015
Merged

Take advantage of Laravel's services.php #6

merged 1 commit into from Nov 18, 2015

Conversation

Max13
Copy link

@Max13 Max13 commented Nov 18, 2015

Laravel provides services.php, a config file made to receive external
services keys

@lahaxearnaud
Copy link
Owner

Hello,

Can you update the readme in order to explain how to set the key in the services.php ?

Thank you for your contribution

@Max13
Copy link
Author

Max13 commented Nov 18, 2015

Hi,
It sounds logical, sorry for that. I will update the readme, and rewrite the *ServiceProvider to allow backward compatibility.

You'll get it during the day.
PS: Should I update the tags also? What would you suggest? Minor or Patch update?

@lahaxearnaud
Copy link
Owner

I will set the tag via github in order to link this issue to the release.

Il you keep backward compatibility it's a patch.

Laravel provides `services.php`, a config file made to receive external
services keys
@Max13
Copy link
Author

Max13 commented Nov 18, 2015

Here is an amended commit

lahaxearnaud added a commit that referenced this pull request Nov 18, 2015
Take advantage of Laravel's services.php
@lahaxearnaud lahaxearnaud merged commit 0eddb41 into lahaxearnaud:master Nov 18, 2015
@lahaxearnaud
Copy link
Owner

tagged v1.1.2

Thank you

@Max13 Max13 deleted the noconfig branch November 18, 2015 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants