#793: Reload division and season data after edit

laingsimon · Mar 4, 2024 · c8d57bc · c8d57bc
1 parent 49bc6c4
commit c8d57bc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/CourageScores/ClientApp/src/components/league/DivisionControls.test.tsx b/CourageScores/ClientApp/src/components/league/DivisionControls.test.tsx
@@ -68,8 +68,8 @@ describe('DivisionControls', () => {
         updatedDivision = null;
     });
 
-    async function divisionOrSeasonChanged(x?: boolean) {
-        changedDivisionOrSeason = x;
+    async function divisionOrSeasonChanged(preventReloadIfIdsAreTheSame?: boolean) {
+        changedDivisionOrSeason = preventReloadIfIdsAreTheSame;
     }
 
     async function renderComponent(props: IDivisionControlsProps, account: UserDto, seasons: SeasonDto[], divisions: DivisionDto[], route?: string, currentPath?: string) {
@@ -601,7 +601,7 @@ describe('DivisionControls', () => {
                 reportedError.verifyNoError();
                 const dialog = context.container.querySelector('.btn-group .modal-dialog');
                 expect(dialog).toBeFalsy();
-                expect(changedDivisionOrSeason).toEqual(true);
+                expect(changedDivisionOrSeason).toEqual(false);
                 expect(reloadSeasonsCalled).toEqual(true);
                 expect(updatedSeason).not.toBeNull();
             });
@@ -665,7 +665,7 @@ describe('DivisionControls', () => {
                 reportedError.verifyNoError();
                 const dialog = context.container.querySelector('.btn-group .modal-dialog');
                 expect(dialog).toBeFalsy();
-                expect(changedDivisionOrSeason).toEqual(true);
+                expect(changedDivisionOrSeason).toEqual(false);
                 expect(reloadDivisionsCalled).toEqual(true);
                 expect(updatedDivision).not.toBeNull();
             });

diff --git a/CourageScores/ClientApp/src/components/league/DivisionControls.tsx b/CourageScores/ClientApp/src/components/league/DivisionControls.tsx
@@ -17,7 +17,7 @@ import {IClientActionResultDto} from "../common/IClientActionResultDto";
 
 export interface IDivisionControlsProps {
     originalSeasonData: DivisionDataSeasonDto;
-    onDivisionOrSeasonChanged?(type?: boolean): Promise<any>;
+    onDivisionOrSeasonChanged?(preventReloadIfIdsAreTheSame?: boolean): Promise<any>;
     originalDivisionData: DivisionDataDto;
     overrideMode?: string;
 }
@@ -64,7 +64,7 @@ export function DivisionControls({originalSeasonData, onDivisionOrSeasonChanged,
                 onSave={async () => {
                     await reloadDivisions();
                     if (onDivisionOrSeasonChanged) {
-                        await onDivisionOrSeasonChanged(true);
+                        await onDivisionOrSeasonChanged(false);
                     }
                     setDivisionData(null);
                 }}
@@ -81,7 +81,7 @@ export function DivisionControls({originalSeasonData, onDivisionOrSeasonChanged,
                 onSave={async () => {
                     await reloadSeasons();
                     if (onDivisionOrSeasonChanged) {
-                        await onDivisionOrSeasonChanged(true);
+                        await onDivisionOrSeasonChanged(false);
                     }
                     setSeasonData(null);
                 }}