Fix update chat visibility (#2566)

Axios send data as body instead query. I can change to send as query instead, but I think send as body is more consistent.
LAION-AI · Apr 16, 2023 · e2074b2 · e2074b2 · hcx1198 · Apr 17, 2023
1 parent 9c05c60
commit e2074b2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/inference/server/oasst_inference_server/routes/chats.py b/inference/server/oasst_inference_server/routes/chats.py
@@ -276,8 +276,8 @@ async def handle_update_title(
 @router.put("/{chat_id}/hide")
 async def update_visibility(
     chat_id: str,
-    hidden: bool = True,
+    request: chat_schema.ChatUpdateVisibilityRequest,
     ucr: UserChatRepository = Depends(deps.create_user_chat_repository),
 ):
-    await ucr.update_visibility(chat_id, hidden)
+    await ucr.update_visibility(chat_id, request.hidden)
     return fastapi.Response(status_code=200)
diff --git a/inference/server/oasst_inference_server/schemas/chat.py b/inference/server/oasst_inference_server/schemas/chat.py
@@ -86,3 +86,7 @@ def __init__(self, message: inference.MessageRead):
 
 class ChatUpdateTitleRequest(pydantic.BaseModel):
     title: pydantic.constr(max_length=100)
+
+
+class ChatUpdateVisibilityRequest(pydantic.BaseModel):
+    hidden: bool
diff --git a/website/src/lib/oasst_inference_client.ts b/website/src/lib/oasst_inference_client.ts
@@ -101,7 +101,7 @@ export class OasstInferenceClient {
   }
 
   hide_chat({ chat_id }: { chat_id: string }) {
-    return this.request(`/chats/${chat_id}/hide`, { method: "PUT", data: { hidden: false } });
+    return this.request(`/chats/${chat_id}/hide`, { method: "PUT", data: { hidden: true } });
   }
 
   delete_account() {