Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude box drawing (TUI) from matches #22

Closed
oblitum opened this issue Nov 1, 2017 · 9 comments
Closed

Exclude box drawing (TUI) from matches #22

oblitum opened this issue Nov 1, 2017 · 9 comments

Comments

@oblitum
Copy link
Contributor

oblitum commented Nov 1, 2017

For example, URL matching for |http://google.com is returning it as |http://google.com, without removing the |.

laktak added a commit that referenced this issue Nov 1, 2017
@laktak
Copy link
Owner

laktak commented Nov 1, 2017

This should work better now (for both url and word filters).

@oblitum
Copy link
Contributor Author

oblitum commented Nov 1, 2017

Actually, I had an issue with the , not |. It's a longer bar used in TUI for creating windows...

@oblitum
Copy link
Contributor Author

oblitum commented Nov 1, 2017

@laktak
Copy link
Owner

laktak commented Nov 1, 2017

I'd rather not add unicode characters to this list. Maybe this could be solved by filtering for unicode blocks - like excluding U+2000 to U+2BFF?

(as a workaround for now you can switch the filter to url)

@oblitum
Copy link
Contributor Author

oblitum commented Nov 1, 2017

Filtering only URLs doesn't sound like a good idea... I use it both for words and URLs. Excluding UNICODE only makes sense at the start of the URLs, because it can be part of both words and URLs.

@laktak
Copy link
Owner

laktak commented Nov 1, 2017

I only meant to exclude the specified blocks, not all of unicode.

@oblitum
Copy link
Contributor Author

oblitum commented Nov 1, 2017

Ah ok, I guess it's reasonable to remove box drawing stuff, because of TUIs.

@laktak laktak changed the title Improve URL matching Exclude box drawing (TUI) from matches Nov 4, 2017
@laktak
Copy link
Owner

laktak commented Nov 4, 2017

@oblitum please test with master

@oblitum
Copy link
Contributor Author

oblitum commented Nov 4, 2017

@laktak OK just fine, issue link opened from neomutt, from where this started 😁

@oblitum oblitum closed this as completed Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants