-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options #7
Add options #7
Conversation
Oh that is a good change, love it! Would it be too much of an ask to add one more configuration option, for the number of lines outside the visible content in the pane? In other words, parameterize the Line 19 in 6c17243
It was briefly discussed in #4. It is especially useful in combination with the |
@maximbaz interesting idea, I like it I don't mind adding it, but since I think it needs some discussion I'd rather handle this in a different PR/ticket for it. I think that instead of adding a config option for "how many lines you want to grab" it may be easier to grasp for a user to pick different presets, like: "grab from all the contents" or "grab only from visible area". Proposed option name: Grabbing from |
I think @laktak also had presets in mind, and I agree that such concept is easier to grasp for a user. I like seeing it how you describe this, it all makes sense to me: name, options, the default. 👍 |
I've created #8 to handle that option, please take a look to see if I missed something. |
I was a bit confused at first beause a vertical split in vim is horizontal in tmux. I'm not a native english speaker so I found this a bit strange to say the least. Anyways ;) thanks for the PR! Looks good but could you change the option names to
(because |
Yeah, while writing this PR I thought something was wrong because of that vim/tmux difference in naming. I'm not a native speaker either :), I guess it may be because you can refer to "horizontal" as "to split horizontally" or "to arrange horizontally". I like your names better, shorter and more meaningful. |
Great, thanks! |
Changes list:
I wanted to have more than the default 6 lines of height on the tmux window and I thought that it may be useful to have extrakto as a sidebar as well on some cases, so I went ahead and added configuration options.
This is how it looks with more height:
This is how it looks as an horizontal sidebar: