Separate distincts workflows #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate two distincts workflows depending on shouldBlockBucketPublicAccess variable. This ease reading and simplify debugging. Ensure any existing OAC is deleted. BREAKING CHANGE: The following IAM rights are now required: ``` - cloudfront:ListOriginAccessControls, - cloudfront:UpdateDistribution, - cloudfront:GetOriginAccessControl ``` Additional IAM right are also necessary if using shouldBlockBucketPublicAccess: ``` - cloudfront:CreateOriginAccessControl, - cloudfront:DeleteOriginAccessControl ```
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 83.18% 82.23% -0.95%
==========================================
Files 13 13
Lines 452 456 +4
Branches 85 85
==========================================
- Hits 376 375 -1
- Misses 76 81 +5 ☔ View full report in Codecov by Sentry. |
MarinMerlin
approved these changes
Jun 4, 2024
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate two distincts workflows depending on
shouldBlockBucketPublicAccess variable. This ease reading and simplify
debugging. Ensure any existing OAC is deleted.
BREAKING CHANGE:
The following IAM rights are now required:
Additional IAM right are also necessary if using
shouldBlockBucketPublicAccess: