Skip to content
This repository has been archived by the owner on Jan 15, 2023. It is now read-only.

feat: Add support for nodejs14.x #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pgrzesik
Copy link

This is an attempt to add support for nodejs14.x runtime. I believe it needs manual action from someone with proper privileges to actually build the base image - it also needs a bit more testing - currently, it follows a similar approach that was used when adding support for nodejs12.x.

I'd love to hear feedback, what is additionally needed and how I can help to get support for nodejs14.x through the finish line/

Thanks in advance

cc @mhart

Closes: #329

@azai91
Copy link

azai91 commented May 6, 2021

when can we merge these changes?

@pgrzesik
Copy link
Author

pgrzesik commented May 6, 2021

@azai91 it needs manual action that will actually dump and upload the runtime. I'm no longer sure this is the best approach in general and a better idea might be to just use the images that AWS released recently

@arzke
Copy link

arzke commented Jul 27, 2021

In our team, we've switched to amazon/aws-sam-cli-build-image-nodejs14.x:latest when upgrading to node 14. It's probably not worth the effort of maintaining this image anymore now that amazon provides official docker images for CI. But it would probably be a good idea to mention in the readme that we now recommend to use official amazon images?

@Kmink
Copy link

Kmink commented Aug 4, 2021

I would vote to merge this in.. We use Serverless (serverless.com) for organizing/test/deploying our serverless infrastructure, and they rely on the lambci/lambda images for local invocations. With no nodejs14.x images available, we can't test our lambda functions locally with that toolset. My hope is that they start to support the Amazon SAM images, but until they do, we're stuck. If this is a fairly straightforward addition, we would certainly appreciate it being made available.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodejs14.x support
5 participants