Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for vita target #86

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Added support for vita target #86

merged 2 commits into from
Nov 7, 2023

Conversation

nikarh
Copy link
Contributor

@nikarh nikarh commented Nov 2, 2023

Added support for tier 3 armv7-sony-vita-newlibeabihf target.

Rust std actually defines that by target_env = "newlib", but I am not entirely sure about other newlib targets.

If the goal is to align with std, I can change it to that.

@sunfishcode
Copy link
Collaborator

I found this code, so it does seem like other newlib targets will use __errno too, so it seems best to follow Rust std here.

@nikarh
Copy link
Contributor Author

nikarh commented Nov 7, 2023

I've updated the PR to use target_env = "newlib".

I didn't remove espidf from cfg. Even though both espidf targets have newlib env in their specs (riscv32imac_esp_espidf and riscv32imc_esp_espidf), it is possible (though highly unlikely) that somebody uses this crate with a custom spec that is not newlib, and a change like that would break this crate for them.

@sunfishcode
Copy link
Collaborator

Sounds good.

@sunfishcode sunfishcode merged commit c10b486 into lambda-fairy:main Nov 7, 2023
11 checks passed
@sunfishcode
Copy link
Collaborator

This is now released in errno 0.3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants