Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cairo-rs version to last commit in main (last PR merged: #742) #202

Merged
merged 13 commits into from
Jan 19, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Jan 6, 2023

Updates cairo-rs version to match the current last commit in cairo-rs

Most notable changes in cairo-rs:

  • new error type HintError

  • new type Felt

  • cairo-rs crate name changed to cairo-vm

Other changes in cairo-rs-py:

  • Swap BigInt for BigUint

@fmoletta fmoletta changed the title Update cairo-rs version after PR##689 Update cairo-rs version after PR#689 Jan 6, 2023
@fmoletta fmoletta changed the title Update cairo-rs version after PR#689 Update cairo-rs version to last commit in main (last PR merged: #729) Jan 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #202 (6c0aad6) into main (5868635) will decrease coverage by 1.04%.
The diff coverage is 89.79%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   95.16%   94.12%   -1.04%     
==========================================
  Files          14       14              
  Lines         724      715       -9     
==========================================
- Hits          689      673      -16     
- Misses         35       42       +7     
Impacted Files Coverage Δ
src/instruction_location.rs 95.23% <ø> (ø)
src/run_context.rs 100.00% <ø> (ø)
src/scope_manager.rs 83.33% <ø> (ø)
src/ids.rs 91.00% <66.66%> (ø)
src/utils.rs 90.00% <80.00%> (-10.00%) ⬇️
src/range_check.rs 92.30% <83.33%> (-7.70%) ⬇️
src/vm_core.rs 91.66% <83.33%> (-5.00%) ⬇️
src/cairo_runner.rs 96.37% <100.00%> (-0.20%) ⬇️
src/ecdsa.rs 100.00% <100.00%> (ø)
src/memory.rs 80.76% <100.00%> (+0.76%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmoletta fmoletta changed the title Update cairo-rs version to last commit in main (last PR merged: #729) Update cairo-rs version to last commit in main (last PR merged: #742) Jan 19, 2023
@fmoletta fmoletta marked this pull request as ready for review January 19, 2023 13:38
Copy link
Contributor

@Juan-M-V Juan-M-V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Juan-M-V Juan-M-V merged commit c3059a5 into main Jan 19, 2023
@Juan-M-V Juan-M-V deleted the substitute-error-message branch January 19, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants