Skip to content

Commit

Permalink
Update changelog entry
Browse files Browse the repository at this point in the history
  • Loading branch information
@fmoletta
fmoletta committed Jan 25, 2023
1 parent b964ff2 commit 0c795f3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* Public Api Changes:
* Change error return type of `CairoRunner::run_from_entrypoint` to `CairoRunError`.
* Convert `VirtualMachineError`s outputed during the vm run to `VmException` in `CairoRunner::run_from_entrypoint`.
* Make `VmException` fields public

* Use CairoArg enum instead of Any in CairoRunner::run_from_entrypoint [#686](https://github.com/lambdaclass/cairo-rs/pull/686)
* Public Api changes:
Expand Down

1 comment on commit 0c795f3

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 0c795f3 Previous: 6807886 Ratio
cairo_run(cairo_programs/benchmarks/compare_arrays_200000.json 1011447868 ns/iter (± 17716318) 695568551 ns/iter (± 14445413) 1.45
cairo_run(cairo_programs/benchmarks/factorial_multirun.json 393906038 ns/iter (± 10294637) 271582473 ns/iter (± 7779582) 1.45
cairo_run(cairo_programs/benchmarks/fibonacci_1000_multirun.json 182180207 ns/iter (± 5905718) 127132080 ns/iter (± 4731708) 1.43
cairo_run(cairo_programs/benchmarks/integration_builtins.json 604817182 ns/iter (± 11929938) 401601735 ns/iter (± 7067063) 1.51
cairo_run(cairo_programs/benchmarks/linear_search.json 127949553 ns/iter (± 5367804) 86492486 ns/iter (± 1414095) 1.48
cairo_run(cairo_programs/benchmarks/keccak_integration_benchmark.json 1861978844 ns/iter (± 35045198) 1265602932 ns/iter (± 21826490) 1.47
cairo_run(cairo_programs/benchmarks/secp_integration_benchmark.json 2229953486 ns/iter (± 44061591) 1406273719 ns/iter (± 14615489) 1.59
cairo_run(cairo_programs/benchmarks/blake2s_integration_benchmark.json 1746666812 ns/iter (± 31231843) 1117106179 ns/iter (± 15541531) 1.56
cairo_run(cairo_programs/benchmarks/dict_integration_benchmark.json 1208839080 ns/iter (± 29617705) 814148531 ns/iter (± 14659143) 1.48
cairo_run(cairo_programs/benchmarks/math_integration_benchmark.json 588088267 ns/iter (± 13595509) 405330751 ns/iter (± 13125060) 1.45
cairo_run(cairo_programs/benchmarks/memory_integration_benchmark.json 637651484 ns/iter (± 15783605) 445998732 ns/iter (± 10801566) 1.43
cairo_run(cairo_programs/benchmarks/math_cmp_and_pow_integration_benchmark.json 26651085 ns/iter (± 1728132) 18316009 ns/iter (± 227718) 1.46
cairo_run(cairo_programs/benchmarks/operations_with_data_structures_benchmarks.json 2670720644 ns/iter (± 60426418) 1742844913 ns/iter (± 31782473) 1.53
cairo_run(cairo_programs/benchmarks/uint256_integration_benchmark.json 1821917715 ns/iter (± 36415235) 1175085616 ns/iter (± 17705744) 1.55
cairo_run(cairo_programs/benchmarks/set_integration_benchmark.json 225585648 ns/iter (± 7300967) 162186987 ns/iter (± 1341343) 1.39

This comment was automatically generated by workflow using github-action-benchmark.

CC: @unbalancedparentheses

Please sign in to comment.