perf: eager resize for ´load_data´

lambdaclass · May 4, 2023 · afef3b7 · afef3b7
1 parent 913aa49
commit afef3b7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 #### Upcoming Changes
 
+* perf: insert elements from the tail in `load_data` so reallocation happens only once [#1117](https://github.com/lambdaclass/cairo-rs/pull/1117)
+
 * Use to_signed_felt as function for felt252 as BigInt within [-P/2, P/2] range and use to_bigint as function for representation as BigInt. [#1100](https://github.com/lambdaclass/cairo-rs/pull/1100)
 
 * Implement hint on field_arithmetic lib [#1090](https://github.com/lambdaclass/cairo-rs/pull/1090)

diff --git a/src/vm/vm_memory/memory_segments.rs b/src/vm/vm_memory/memory_segments.rs
@@ -55,7 +55,9 @@ impl MemorySegmentManager {
         ptr: Relocatable,
         data: &Vec<MaybeRelocatable>,
     ) -> Result<Relocatable, MemoryError> {
-        for (num, value) in data.iter().enumerate() {
+        // Starting from the end ensures any necessary resize
+        // is performed once with enough room for everything
+        for (num, value) in data.iter().enumerate().rev() {
             self.memory.insert((ptr + num)?, value)?;
         }
         (ptr + data.len()).map_err(MemoryError::Math)