Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement hints on field_arithmetic lib (Part 2) #1004

Merged
merged 88 commits into from
Apr 22, 2023
Merged

feat: Implement hints on field_arithmetic lib (Part 2) #1004

merged 88 commits into from
Apr 22, 2023

Commits on Apr 11, 2023

  1. Add hint code for UINT348_UNSIGNED_DIV_REM

    @fmoletta
    fmoletta committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ada5a2b View commit details
    Browse the repository at this point in the history

  2. Add file for uint348 files

    @fmoletta
    fmoletta committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d1b7e84 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Add pack & split for uint348

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c409d01 View commit details
    Browse the repository at this point in the history

  2. Move comment

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    93c6f4e View commit details
    Browse the repository at this point in the history

  3. Implement uint348_unsigned_div_rem hint

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    82dbf2b View commit details
    Browse the repository at this point in the history

  4. Add integration test

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    df9deb2 View commit details
    Browse the repository at this point in the history

  5. Add integration test

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    7b2f5d9 View commit details
    Browse the repository at this point in the history

  6. Add unit tests

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    b1a3fbb View commit details
    Browse the repository at this point in the history

  7. Add hint on split_128

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    110605a View commit details
    Browse the repository at this point in the history

  8. Test split_128 hint

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    8cc3ce7 View commit details
    Browse the repository at this point in the history

  9. Add add_no_uint384_hint

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    378788d View commit details
    Browse the repository at this point in the history

  10. Fix hint + add tests

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    271a38c View commit details
    Browse the repository at this point in the history

  11. Add hint code for UINT348_UNSIGNED_DIV_REM_EXPAND

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    ed7de28 View commit details
    Browse the repository at this point in the history

  12. Msc fixes

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    be408c3 View commit details
    Browse the repository at this point in the history

  13. Add integration test

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    8c6fb8c View commit details
    Browse the repository at this point in the history

  14. Reduce Uint384_expand representation to the 3 used limbs

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    512a80e View commit details
    Browse the repository at this point in the history

  15. Add unit test

    @fmoletta
    fmoletta committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    089398e View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Add hint code for UINT384_SQRT

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    6852a87 View commit details
    Browse the repository at this point in the history

  2. Add implementation for hint on sqrt

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e3e05be View commit details
    Browse the repository at this point in the history

  3. Integration test

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    faf4765 View commit details
    Browse the repository at this point in the history

  4. Add unit tests

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    d30d404 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:lambdaclass/cairo-rs into uint348-h… 

    …ints
    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    aa9ce34 View commit details
    Browse the repository at this point in the history

  6. Fix missing directive

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f257b56 View commit details
    Browse the repository at this point in the history

  7. Run cairo-format

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    4218e80 View commit details
    Browse the repository at this point in the history

  8. Add changelog entry

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e1d0100 View commit details
    Browse the repository at this point in the history

  9. Spelling

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    51c7dc3 View commit details
    Browse the repository at this point in the history

  10. Add hint code + Uint768 type

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f340a3a View commit details
    Browse the repository at this point in the history

  11. Implement hint unsigned_div_rem_uint768_by_uint384

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    08ebafb View commit details
    Browse the repository at this point in the history

  12. Update src/hint_processor/builtin_hint_processor/uint384.rs 

    Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
    @fmoletta @Oppen
    fmoletta and Oppen committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    3f8bdfb View commit details
    Browse the repository at this point in the history

  13. Update src/hint_processor/builtin_hint_processor/uint384.rs 

    Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
    @fmoletta @Oppen
    fmoletta and Oppen committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    43f3977 View commit details
    Browse the repository at this point in the history

  14. Update src/hint_processor/builtin_hint_processor/uint384.rs 

    Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
    @fmoletta @Oppen
    fmoletta and Oppen committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0045914 View commit details
    Browse the repository at this point in the history

  15. Make hint code more readable

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    4f89202 View commit details
    Browse the repository at this point in the history

  16. Add integration test

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    c4b7f6e View commit details
    Browse the repository at this point in the history

  17. Add test

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f0400b9 View commit details
    Browse the repository at this point in the history

  18. Add unit test

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    a0368e2 View commit details
    Browse the repository at this point in the history

  19. Add changelog entry + fmt

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    ce01868 View commit details
    Browse the repository at this point in the history

  20. Fix plural

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    bd3214a View commit details
    Browse the repository at this point in the history

  21. Merge branch 'uint348-hints' into uint384-hints-extended

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f6359ad View commit details
    Browse the repository at this point in the history

  22. cargo fmt

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    96bc852 View commit details
    Browse the repository at this point in the history

  23. Add first draft of get_square_root

    @fmoletta
    fmoletta committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    bf5a22c View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Fix test

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    1ada5b3 View commit details
    Browse the repository at this point in the history

  2. Fix syntax

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    764e28a View commit details
    Browse the repository at this point in the history

  3. Fix test

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    b259bd0 View commit details
    Browse the repository at this point in the history

  4. Add necessary lib fns

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    ffe9508 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into uint348-hints

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    24e06fe View commit details
    Browse the repository at this point in the history

  6. fix fmt

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    6861479 View commit details
    Browse the repository at this point in the history

  7. Fix test value

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    4f094b4 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'uint348-hints' into uint384-hints-extended

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    4059972 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'uint384-hints-extended' into field-arithmetic-hints

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    ec67ecb View commit details
    Browse the repository at this point in the history

  10. Add test program

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    18011e0 View commit details
    Browse the repository at this point in the history

  11. Add hint to execute_hint

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    afe1cca View commit details
    Browse the repository at this point in the history

  12. Fix wrong hint being tested

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    355b836 View commit details
    Browse the repository at this point in the history

  13. Implement sqrt

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    9c159ef View commit details
    Browse the repository at this point in the history

  14. Add test fix file

    @fmoletta
    fmoletta committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    9c5db20 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Fix _sqrt_mod_tonelli_shanks implementation

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    e9982da View commit details
    Browse the repository at this point in the history

  2. Expand integration test

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    c3be7b3 View commit details
    Browse the repository at this point in the history

  3. Add unit test

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    376cd3d View commit details
    Browse the repository at this point in the history

  4. Add proptests

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6906494 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:lambdaclass/cairo-rs into uint384-h… 

    …ints-extended
    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    40ad285 View commit details
    Browse the repository at this point in the history

  6. Fix merge conflict

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    fee4a04 View commit details
    Browse the repository at this point in the history

  7. Fix merge conflict

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    3284a6d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'uint384-hints-extended' into field-arithmetic-hints

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    0032e0a View commit details
    Browse the repository at this point in the history

  9. Add changelog entry

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b61d958 View commit details
    Browse the repository at this point in the history

  10. Use no-std compatible rng when std is not enabled

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    fc9573f View commit details
    Browse the repository at this point in the history

  11. Clippy

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ed1c58c View commit details
    Browse the repository at this point in the history

  12. Use seeded rng instead of from_entropy

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    37bdc30 View commit details
    Browse the repository at this point in the history

  13. Catch potential zero divison errors

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    03eb74c View commit details
    Browse the repository at this point in the history

  14. Implement hint on div

    @fmoletta
    fmoletta committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    e1a04e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Expand field_arithmetic integration test

    @fmoletta
    fmoletta committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    0ef37db View commit details
    Browse the repository at this point in the history

  2. Expand field_arithmetic integration test

    @fmoletta
    fmoletta committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    b3698ad View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Add test + fix hint

    @fmoletta
    fmoletta committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    7b2329a View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Merge branch 'main' of github.com:lambdaclass/cairo-rs into field-ari… 

    …thmetic-hints-2
    @fmoletta
    fmoletta committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    e307630 View commit details
    Browse the repository at this point in the history

  2. Fix merge conflict

    @fmoletta
    fmoletta committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    e9f2ea4 View commit details
    Browse the repository at this point in the history

  3. Use mul_inv instead of div_mod

    @fmoletta
    fmoletta committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    415dab3 View commit details
    Browse the repository at this point in the history

  4. Add Changelog entry

    @fmoletta
    fmoletta committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    75ce158 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Add unit tests

    @fmoletta
    fmoletta committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    3f3bd6d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:lambdaclass/cairo-rs into field-ari… 

    …thmetic-hints-2
    @fmoletta
    fmoletta committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f72a78e View commit details
    Browse the repository at this point in the history

  3. remove unused feature

    @fmoletta
    fmoletta committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a4670bd View commit details
    Browse the repository at this point in the history

  4. Fix test value

    @fmoletta
    fmoletta committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    b617b78 View commit details
    Browse the repository at this point in the history

  5. Update cairo_programs/field_arithmetic.cairo 

    Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
    @fmoletta @Oppen
    fmoletta and Oppen committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    188ec9d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into field-arithmetic-hints-2

    @fmoletta
    fmoletta committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7c7ebda View commit details
    Browse the repository at this point in the history

  7. Increase number of memory holes for field_arithmetic test

    @fmoletta
    fmoletta committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    fa86261 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into field-arithmetic-hints-2

    @fmoletta
    fmoletta committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    4c6c1e4 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' of github.com:lambdaclass/cairo-rs into field-ari… 

    …thmetic-hints-2
    @fmoletta
    fmoletta committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    c942dc6 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'field-arithmetic-hints-2' of github.com:lambdaclass/cai… 

    …ro-rs into field-arithmetic-hints-2
    @fmoletta
    fmoletta committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    77864d1 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into field-arithmetic-hints-2

    @fmoletta
    fmoletta committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    6048ec2 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. Merge branch 'main' into field-arithmetic-hints-2

    @Oppen
    Oppen committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    77024e8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into field-arithmetic-hints-2

    @Oppen
    Oppen committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    26aaacf View commit details
    Browse the repository at this point in the history