-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): add NewHint#43 #1016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 19, 2023 20:09
MegaRedHand
changed the base branch from
main
to
newhint42-u256_expanded_div_rem
April 19, 2023 20:09
MegaRedHand
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 19, 2023
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1016 +/- ##
========================================
Coverage 98.05% 98.05%
========================================
Files 77 77
Lines 31944 32058 +114
========================================
+ Hits 31322 31436 +114
Misses 622 622
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Apr 20, 2023
MegaRedHand
force-pushed
the
newhint43-u256_sub
branch
from
April 20, 2023 14:16
ac05d71
to
a8eed41
Compare
Oppen
approved these changes
Apr 20, 2023
pefontana
approved these changes
Apr 20, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add NewHint#43 * Update changelog * Add test for missing members * Remove derive * Refactor insertion of Uint256 * Remove duplicated import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing hint NewHint#43, now known as
UINT256_SUB
. This also introduces a new wrapper typeUint256
for a set of twoCow
s loaded from VM memory. Olduint256
utils should be refactored to use it in the future.