Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hint): support hint #66 for keccak_finalize #1041

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

Oppen
Copy link
Member

@Oppen Oppen commented Apr 24, 2023

Version from whitelist starknet/security/whitelists/cairo_keccak.json, differs from the current one in bounds for _block_size, 1000 instead of 10.

Affects #1020

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Apr 24, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 2.501 ± 0.050 2.458 2.617 1.01 ± 0.03
head blake2s_integration_benchmark 2.485 ± 0.057 2.437 2.584 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.062 ± 0.041 3.022 3.133 1.01 ± 0.02
head compare_arrays_200000 3.030 ± 0.031 3.009 3.093 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.422 ± 0.041 2.401 2.535 1.00 ± 0.03
head dict_integration_benchmark 2.422 ± 0.058 2.382 2.532 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 3.700 ± 0.016 3.685 3.738 1.00
head factorial_multirun 3.703 ± 0.024 3.671 3.747 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 2.968 ± 0.003 2.964 2.975 1.00 ± 0.01
head fibonacci_1000_multirun 2.963 ± 0.015 2.952 2.999 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 129.0 ± 4.0 126.5 139.8 1.01 ± 0.03
head field_arithmetic_get_square_benchmark 127.3 ± 1.2 125.5 129.2 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 2.929 ± 0.012 2.922 2.962 1.00 ± 0.01
head integration_builtins 2.928 ± 0.023 2.908 2.983 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 2.648 ± 0.013 2.631 2.670 1.01 ± 0.01
head keccak_integration_benchmark 2.633 ± 0.015 2.618 2.666 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.135 ± 0.004 3.129 3.143 1.00 ± 0.00
head linear_search 3.133 ± 0.014 3.119 3.158 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.672 ± 0.013 2.656 2.694 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 2.668 ± 0.011 2.650 2.687 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.466 ± 0.007 2.458 2.476 1.00 ± 0.01
head math_integration_benchmark 2.458 ± 0.015 2.447 2.495 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.136 ± 0.013 2.121 2.167 1.01 ± 0.01
head memory_integration_benchmark 2.123 ± 0.006 2.115 2.133 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.207 ± 0.010 2.192 2.218 1.01 ± 0.01
head operations_with_data_structures_benchmarks 2.191 ± 0.018 2.179 2.239 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 777.4 ± 4.9 772.5 789.8 1.00
head pedersen 779.1 ± 3.4 774.4 786.9 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.497 ± 0.014 1.487 1.536 1.00 ± 0.01
head poseidon_integration_benchmark 1.491 ± 0.006 1.482 1.498 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.355 ± 0.007 2.347 2.371 1.00
head secp_integration_benchmark 2.358 ± 0.014 2.338 2.391 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.677 ± 0.009 1.667 1.699 1.00
head set_integration_benchmark 1.693 ± 0.015 1.681 1.733 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.892 ± 0.012 3.875 3.908 1.00 ± 0.00
head uint256_integration_benchmark 3.879 ± 0.013 3.861 3.899 1.00

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1041 (a238b43) into main (fb73125) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a238b43 differs from pull request most recent head 83e7f87. Consider uploading reports for the commit 83e7f87 to get more accurate results

@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
- Coverage   98.08%   98.07%   -0.01%     
==========================================
  Files          81       80       -1     
  Lines       33126    33052      -74     
==========================================
- Hits        32491    32417      -74     
  Misses        635      635              
Impacted Files Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 98.86% <100.00%> (-0.01%) ⬇️
...uiltin_hint_processor/cairo_keccak/keccak_hints.rs 94.35% <100.00%> (+0.41%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen force-pushed the feat(hint)/66-cairo_keccak_finalize_v2 branch from 5987533 to b761b20 Compare April 24, 2023 16:43
@Oppen Oppen changed the title feat(hint): support hint #68 for keccak_finalize feat(hint): support hint #66 for keccak_finalize Apr 24, 2023
@pefontana pefontana added the whitelisted-hint Implementation of hint on whitelist directory label Apr 24, 2023
Copy link
Member

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Oppen Oppen added this pull request to the merge queue Apr 24, 2023
@Oppen Oppen removed this pull request from the merge queue due to a manual request Apr 24, 2023
@Oppen Oppen enabled auto-merge April 24, 2023 19:14
@Oppen Oppen force-pushed the feat(hint)/66-cairo_keccak_finalize_v2 branch 2 times, most recently from 7f9e9ab to 816ae94 Compare April 24, 2023 20:54
Version from whitelist `starknet/security/whitelists/cairo_keccak.json`,
differs from the current one in bounds for `_block_size`, `1000` instead
of `10`.
@Oppen Oppen force-pushed the feat(hint)/66-cairo_keccak_finalize_v2 branch from 816ae94 to 83e7f87 Compare April 24, 2023 21:24
@Oppen Oppen added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit 50c90d9 Apr 24, 2023
15 checks passed
@Oppen Oppen deleted the feat(hint)/66-cairo_keccak_finalize_v2 branch April 24, 2023 22:25
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
…ass#1041)

Version from whitelist `starknet/security/whitelists/cairo_keccak.json`,
differs from the current one in bounds for `_block_size`, `1000` instead
of `10`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whitelisted-hint Implementation of hint on whitelist directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants