-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hint): support hint #66 for keccak_finalize #1041
Conversation
bf553e8
to
5987533
Compare
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
- Coverage 98.08% 98.07% -0.01%
==========================================
Files 81 80 -1
Lines 33126 33052 -74
==========================================
- Hits 32491 32417 -74
Misses 635 635
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
5987533
to
b761b20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
7f9e9ab
to
816ae94
Compare
Version from whitelist `starknet/security/whitelists/cairo_keccak.json`, differs from the current one in bounds for `_block_size`, `1000` instead of `10`.
816ae94
to
83e7f87
Compare
…ass#1041) Version from whitelist `starknet/security/whitelists/cairo_keccak.json`, differs from the current one in bounds for `_block_size`, `1000` instead of `10`.
Version from whitelist
starknet/security/whitelists/cairo_keccak.json
, differs from the current one in bounds for_block_size
,1000
instead of10
.Affects #1020
Checklist