Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: keep min and max referenced offsets during run #1080

Merged
merged 28 commits into from
Jun 13, 2023

Conversation

Oppen
Copy link
Member

@Oppen Oppen commented Apr 27, 2023

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 14.216 ± 0.102 14.123 14.437 1.12 ± 0.01
head blake2s_integration_benchmark 12.691 ± 0.042 12.637 12.765 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.787 ± 0.040 4.747 4.864 1.06 ± 0.02
head compare_arrays_200000 4.515 ± 0.092 4.435 4.663 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.095 ± 0.015 3.079 3.131 1.05 ± 0.01
head dict_integration_benchmark 2.934 ± 0.010 2.919 2.952 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.976 ± 0.024 4.942 5.030 1.05 ± 0.01
head factorial_multirun 4.724 ± 0.024 4.692 4.764 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.251 ± 0.017 4.226 4.276 1.08 ± 0.01
head fibonacci_1000_multirun 3.939 ± 0.017 3.922 3.967 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 198.3 ± 2.3 195.7 202.0 1.05 ± 0.01
head field_arithmetic_get_square_benchmark 189.4 ± 1.2 186.4 190.9 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 12.739 ± 0.281 12.455 13.409 1.12 ± 0.03
head integration_builtins 11.341 ± 0.136 11.167 11.592 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 14.512 ± 0.221 14.295 15.074 1.13 ± 0.02
head keccak_integration_benchmark 12.883 ± 0.144 12.749 13.133 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.744 ± 0.030 4.714 4.813 1.06 ± 0.01
head linear_search 4.471 ± 0.039 4.430 4.576 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.299 ± 0.023 3.271 3.335 1.04 ± 0.01
head math_cmp_and_pow_integration_benchmark 3.160 ± 0.022 3.131 3.209 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.063 ± 0.015 3.036 3.083 1.05 ± 0.02
head math_integration_benchmark 2.929 ± 0.045 2.896 3.049 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.688 ± 0.012 2.671 2.712 1.05 ± 0.01
head memory_integration_benchmark 2.559 ± 0.024 2.540 2.613 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 3.061 ± 0.017 3.028 3.082 1.06 ± 0.01
head operations_with_data_structures_benchmarks 2.880 ± 0.023 2.856 2.924 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.046 ± 0.004 1.037 1.051 1.04 ± 0.01
head pedersen 1.006 ± 0.003 1.003 1.014 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.881 ± 0.048 1.852 2.006 1.04 ± 0.03
head poseidon_integration_benchmark 1.817 ± 0.007 1.798 1.823 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.618 ± 0.061 3.568 3.757 1.05 ± 0.02
head secp_integration_benchmark 3.455 ± 0.008 3.440 3.467 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.834 ± 0.011 1.816 1.854 1.01 ± 0.01
head set_integration_benchmark 1.813 ± 0.013 1.798 1.847 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.897 ± 0.021 8.874 8.936 1.09 ± 0.01
head uint256_integration_benchmark 8.160 ± 0.057 8.098 8.296 1.00

@Oppen Oppen force-pushed the perf/running_perm_range_check_limits branch 3 times, most recently from eba668e to a37116b Compare May 3, 2023 19:40
@Oppen Oppen force-pushed the perf/running_perm_range_check_limits branch from a37116b to 42c2455 Compare May 11, 2023 21:10
@Oppen Oppen marked this pull request as ready for review June 10, 2023 02:59
@Oppen Oppen requested a review from igaray as a code owner June 10, 2023 02:59
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #1080 (811fb5c) into main (6d8d492) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
+ Coverage   97.60%   97.61%   +0.01%     
==========================================
  Files          89       88       -1     
  Lines       36205    36112      -93     
==========================================
- Hits        35337    35251      -86     
+ Misses        868      861       -7     
Impacted Files Coverage Δ
vm/src/vm/runners/cairo_runner.rs 98.02% <100.00%> (+0.02%) ⬆️
vm/src/vm/trace/mod.rs 100.00% <100.00%> (+2.89%) ⬆️
vm/src/vm/vm_core.rs 97.80% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MegaRedHand MegaRedHand added this pull request to the merge queue Jun 13, 2023
Merged via the queue into main with commit 4221723 Jun 13, 2023
31 checks passed
@MegaRedHand MegaRedHand deleted the perf/running_perm_range_check_limits branch June 13, 2023 22:11
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* Fix trace

* WIP

* Revert "WIP"

This reverts commit eae76bb92a33de5dd5f488a08efe18b91846b2dd.

* test: remove no longer relevant tests

* Fix missing reassignment of cache

* Cleanup and correctness

* chore: changelog

* refactor: don't return Result

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Co-authored-by: Tomá <47506558+MegaRedHand@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants