-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): add NewHint#34 #1091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1091 +/- ##
========================================
Coverage 98.11% 98.11%
========================================
Files 84 84
Lines 34231 34419 +188
========================================
+ Hits 33585 33771 +186
- Misses 646 648 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fmoletta
reviewed
Apr 27, 2023
fmoletta
reviewed
Apr 27, 2023
fmoletta
reviewed
Apr 27, 2023
fmoletta
reviewed
Apr 27, 2023
fmoletta
reviewed
Apr 27, 2023
fmoletta
reviewed
Apr 27, 2023
fmoletta
reviewed
Apr 27, 2023
Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com>
fmoletta
approved these changes
Apr 28, 2023
pefontana
approved these changes
Apr 28, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add NewHint#34 Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> * Update changelog * Change `let` + `assert` for `assert` Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> * Change AssertionFailed messages * Change let + assert for simple assert --------- Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #974
Description
This PR adds the missing hint NewHint#34, now known as
SHA256_MAIN_ARBITRARY_INPUT_LENGTH
. Also renamesSHA256_MAIN
toSHA256_MAIN_CONSTANT_INPUT_LENGTH
. As part of the changes, extract helper functionget_constant_from_var_name
used for retrieving a constant fromconstants
HashMap
.