Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix hint BIGINT_PACK_DIV_MOD #1189

Merged
merged 4 commits into from
May 30, 2023
Merged

bugfix: Fix hint BIGINT_PACK_DIV_MOD #1189

merged 4 commits into from
May 30, 2023

Conversation

fmoletta
Copy link
Member

After the changes in the felt lib, this hint was still using to_bigint instead of to_signed_felt

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@fmoletta fmoletta changed the title bugfix: Fix hint BIGINT_PACK_DIV_MOD bugfix: Fix hint BIGINT_PACK_DIV_MOD May 30, 2023
@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 14.753 ± 0.096 14.619 14.903 1.00
head blake2s_integration_benchmark 14.865 ± 0.105 14.772 15.110 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.933 ± 0.070 4.872 5.096 1.00
head compare_arrays_200000 4.976 ± 0.034 4.940 5.039 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.298 ± 0.040 3.263 3.391 1.00
head dict_integration_benchmark 3.318 ± 0.060 3.282 3.485 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 5.209 ± 0.032 5.177 5.287 1.00
head factorial_multirun 5.238 ± 0.028 5.198 5.279 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.477 ± 0.016 4.456 4.504 1.00
head fibonacci_1000_multirun 4.500 ± 0.017 4.478 4.534 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 219.4 ± 2.2 217.8 225.1 1.00
head field_arithmetic_get_square_benchmark 220.4 ± 0.9 219.4 222.7 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 13.552 ± 0.166 13.333 13.917 1.01 ± 0.01
head integration_builtins 13.473 ± 0.040 13.391 13.532 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 15.261 ± 0.791 14.764 17.400 1.01 ± 0.06
head keccak_integration_benchmark 15.051 ± 0.468 14.808 16.345 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.929 ± 0.015 4.909 4.952 1.00
head linear_search 4.971 ± 0.052 4.937 5.112 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.581 ± 0.041 3.539 3.678 1.00
head math_cmp_and_pow_integration_benchmark 3.891 ± 0.835 3.579 6.253 1.09 ± 0.23
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.306 ± 0.026 3.281 3.373 1.00
head math_integration_benchmark 3.337 ± 0.017 3.316 3.360 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.822 ± 0.047 2.783 2.920 1.00
head memory_integration_benchmark 2.826 ± 0.045 2.780 2.927 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 3.280 ± 0.027 3.256 3.345 1.00
head operations_with_data_structures_benchmarks 3.290 ± 0.008 3.276 3.303 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.066 ± 0.005 1.062 1.077 1.00
head pedersen 1.067 ± 0.002 1.064 1.071 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.901 ± 0.005 1.895 1.909 1.00
head poseidon_integration_benchmark 1.908 ± 0.006 1.901 1.919 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 4.072 ± 0.021 4.052 4.127 1.00
head secp_integration_benchmark 4.104 ± 0.022 4.080 4.161 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.386 ± 0.007 2.375 2.399 1.07 ± 0.01
head set_integration_benchmark 2.233 ± 0.013 2.217 2.254 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 9.584 ± 0.032 9.555 9.659 1.00
head uint256_integration_benchmark 9.631 ± 0.031 9.590 9.680 1.00 ± 0.00

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #1189 (d7f6496) into main (16db8ee) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
- Coverage   97.70%   97.70%   -0.01%     
==========================================
  Files          89       89              
  Lines       35936    35930       -6     
==========================================
- Hits        35113    35107       -6     
  Misses        823      823              
Impacted Files Coverage Δ
...rc/hint_processor/builtin_hint_processor/bigint.rs 97.65% <100.00%> (-0.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juanbono juanbono added this pull request to the merge queue May 30, 2023
Merged via the queue into main with commit e06c560 May 30, 2023
32 checks passed
@juanbono juanbono deleted the fix-bigint-pack-divmod branch May 30, 2023 14:58
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Use `to_signed_felt` instead of `to_bigint`

* fmt

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants