Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Program.builtins_len() method #1194

Merged
merged 2 commits into from
May 31, 2023
Merged

Add Program.builtins_len() method #1194

merged 2 commits into from
May 31, 2023

Conversation

pefontana
Copy link
Member

Add Program.builtins_len() method

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@pefontana pefontana marked this pull request as ready for review May 31, 2023 14:59
Copy link
Member

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanbono juanbono enabled auto-merge May 31, 2023 15:00
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1194 (5f798e9) into main (09ea750) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1194   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          89       89           
  Lines       35968    35972    +4     
=======================================
+ Hits        35140    35144    +4     
  Misses        828      828           
Impacted Files Coverage Δ
src/types/program.rs 99.46% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 11.766 ± 0.220 11.579 12.277 1.01 ± 0.02
head blake2s_integration_benchmark 11.690 ± 0.087 11.613 11.848 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.856 ± 0.038 3.824 3.939 1.00
head compare_arrays_200000 3.878 ± 0.044 3.835 3.977 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.640 ± 0.027 2.608 2.692 1.01 ± 0.01
head dict_integration_benchmark 2.621 ± 0.011 2.607 2.641 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 3.964 ± 0.018 3.948 3.995 1.00 ± 0.01
head factorial_multirun 3.952 ± 0.016 3.934 3.985 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.474 ± 0.057 3.411 3.596 1.00 ± 0.02
head fibonacci_1000_multirun 3.473 ± 0.061 3.428 3.639 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 179.1 ± 8.6 173.8 200.8 1.01 ± 0.05
head field_arithmetic_get_square_benchmark 177.0 ± 1.9 174.9 181.2 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 10.443 ± 0.167 10.247 10.750 1.00
head integration_builtins 10.474 ± 0.108 10.305 10.652 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 12.091 ± 0.314 11.800 12.857 1.01 ± 0.03
head keccak_integration_benchmark 11.952 ± 0.220 11.640 12.331 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.886 ± 0.031 3.854 3.952 1.00 ± 0.01
head linear_search 3.881 ± 0.024 3.841 3.921 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.792 ± 0.045 2.763 2.888 1.01 ± 0.02
head math_cmp_and_pow_integration_benchmark 2.758 ± 0.013 2.743 2.787 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.608 ± 0.017 2.593 2.637 1.00 ± 0.01
head math_integration_benchmark 2.608 ± 0.016 2.583 2.636 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.211 ± 0.019 2.187 2.254 1.01 ± 0.01
head memory_integration_benchmark 2.196 ± 0.009 2.180 2.209 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.576 ± 0.017 2.559 2.614 1.00 ± 0.01
head operations_with_data_structures_benchmarks 2.575 ± 0.014 2.560 2.602 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 872.2 ± 9.6 863.6 891.7 1.00 ± 0.01
head pedersen 870.0 ± 3.3 866.4 876.7 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.615 ± 0.021 1.602 1.673 1.00 ± 0.01
head poseidon_integration_benchmark 1.613 ± 0.008 1.605 1.633 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.081 ± 0.021 3.066 3.135 1.00 ± 0.01
head secp_integration_benchmark 3.081 ± 0.015 3.063 3.118 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.753 ± 0.004 1.747 1.758 1.00
head set_integration_benchmark 1.763 ± 0.018 1.749 1.802 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.643 ± 0.038 7.596 7.730 1.00
head uint256_integration_benchmark 7.675 ± 0.062 7.591 7.759 1.00 ± 0.01

@juanbono juanbono added this pull request to the merge queue May 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 31, 2023
@pefontana pefontana added this pull request to the merge queue May 31, 2023
Merged via the queue into main with commit 5db2e65 May 31, 2023
32 checks passed
@pefontana pefontana deleted the Program-builtins_len branch May 31, 2023 16:34
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Add Program.builtins_len() method

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants