Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: implement mem_eq and use it for set_add #1198

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

Oppen
Copy link
Member

@Oppen Oppen commented Jun 1, 2023

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pefontana pefontana enabled auto-merge June 1, 2023 18:17
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 12.790 ± 0.140 12.653 13.101 1.00
head blake2s_integration_benchmark 12.997 ± 0.124 12.816 13.192 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.097 ± 0.040 4.051 4.174 1.00
head compare_arrays_200000 4.149 ± 0.047 4.111 4.245 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.707 ± 0.049 2.678 2.842 1.00
head dict_integration_benchmark 2.726 ± 0.021 2.707 2.772 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.307 ± 0.063 4.247 4.466 1.00
head factorial_multirun 4.325 ± 0.056 4.264 4.420 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.732 ± 0.021 3.693 3.766 1.00
head fibonacci_1000_multirun 3.775 ± 0.020 3.753 3.818 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 185.0 ± 6.1 180.4 197.6 1.00
head field_arithmetic_get_square_benchmark 186.4 ± 4.4 183.1 198.1 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 11.958 ± 0.228 11.751 12.483 1.00
head integration_builtins 12.065 ± 0.117 11.865 12.254 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 13.069 ± 0.172 12.857 13.480 1.00
head keccak_integration_benchmark 13.070 ± 0.106 12.936 13.249 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.057 ± 0.026 4.022 4.109 1.00
head linear_search 4.113 ± 0.024 4.084 4.161 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.829 ± 0.009 2.815 2.844 1.00
head math_cmp_and_pow_integration_benchmark 2.847 ± 0.012 2.830 2.868 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.660 ± 0.010 2.645 2.675 1.00
head math_integration_benchmark 2.691 ± 0.027 2.670 2.759 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.299 ± 0.011 2.287 2.326 1.00
head memory_integration_benchmark 2.338 ± 0.021 2.315 2.385 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.624 ± 0.028 2.592 2.693 1.00
head operations_with_data_structures_benchmarks 2.660 ± 0.014 2.638 2.685 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 899.2 ± 9.0 891.8 923.6 1.00
head pedersen 903.7 ± 6.2 899.0 919.6 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.647 ± 0.020 1.632 1.701 1.00 ± 0.01
head poseidon_integration_benchmark 1.641 ± 0.008 1.631 1.656 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.178 ± 0.022 3.154 3.231 1.00
head secp_integration_benchmark 3.201 ± 0.026 3.176 3.257 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.346 ± 0.003 1.342 1.349 1.00
head set_integration_benchmark 1.488 ± 0.016 1.471 1.519 1.11 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.089 ± 0.050 8.007 8.183 1.00
head uint256_integration_benchmark 8.173 ± 0.028 8.140 8.245 1.01 ± 0.01

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #1198 (d2e83e6) into main (cf5768c) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1198      +/-   ##
==========================================
- Coverage   97.62%   97.60%   -0.03%     
==========================================
  Files          89       89              
  Lines       36038    36066      +28     
==========================================
+ Hits        35182    35202      +20     
- Misses        856      864       +8     
Impacted Files Coverage Δ
src/vm/vm_memory/memory.rs 98.57% <80.76%> (-0.40%) ⬇️
src/hint_processor/builtin_hint_processor/set.rs 99.09% <100.00%> (-0.01%) ⬇️
src/vm/vm_core.rs 97.78% <100.00%> (-0.10%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana added this pull request to the merge queue Jun 1, 2023
@pefontana pefontana removed this pull request from the merge queue due to a manual request Jun 1, 2023
@pefontana pefontana added this pull request to the merge queue Jun 1, 2023
Merged via the queue into main with commit de6a232 Jun 1, 2023
30 of 31 checks passed
@pefontana pefontana deleted the perf/set_mem_eq branch June 1, 2023 21:02
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants