build(vm): remove unused implicit features #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1266 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 89 89
Lines 36335 36335
=======================================
Hits 35466 35466
Misses 869 869 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tdelabro
force-pushed
the
fix-useless-cairo-vm-features
branch
from
d3dc1b8
to
dc8e77e
Compare
MegaRedHand
approved these changes
Jun 22, 2023
fmoletta
approved these changes
Jun 23, 2023
tdelabro
force-pushed
the
fix-useless-cairo-vm-features
branch
from
dc8e77e
to
fa61edc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As stated in the rust doc
In some cases, you may not want to expose a feature that has the same name as the optional dependency. For example, perhaps the optional dependency is an internal detail, or you want to group multiple optional dependencies together, or you just want to use a better name. If you specify the optional dependency with the dep: prefix anywhere in the [features] table, that disables the implicit feature.This makes sure no implicit features are created for the optional crates that are imported only to be used in another feature.