Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CLI error message #1270

Merged
merged 7 commits into from
Jun 23, 2023
Merged

fix: CLI error message #1270

merged 7 commits into from
Jun 23, 2023

Conversation

matias-gonz
Copy link
Contributor

@matias-gonz matias-gonz commented Jun 21, 2023

Fix CLI error message

Description

Closes #1263

Checklist

  • Linked to Github Issue

@matias-gonz matias-gonz self-assigned this Jun 21, 2023
@matias-gonz matias-gonz changed the title Fix CLI error message fix: CLI error message Jun 21, 2023
@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 10.463 ± 0.473 10.196 11.776 1.02 ± 0.05
head blake2s_integration_benchmark 10.235 ± 0.098 10.154 10.455 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.494 ± 0.074 3.435 3.665 1.00
head compare_arrays_200000 3.500 ± 0.042 3.465 3.609 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.350 ± 0.012 2.332 2.370 1.00
head dict_integration_benchmark 2.361 ± 0.018 2.345 2.396 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 3.662 ± 0.029 3.621 3.725 1.00
head factorial_multirun 3.675 ± 0.016 3.655 3.711 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.085 ± 0.030 3.038 3.136 1.00
head fibonacci_1000_multirun 3.093 ± 0.007 3.084 3.108 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.832 ± 0.005 1.824 1.843 1.00
head field_arithmetic_get_square_benchmark 1.876 ± 0.039 1.849 1.977 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.884 ± 0.128 8.746 9.209 1.00
head integration_builtins 8.936 ± 0.085 8.833 9.065 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 10.368 ± 0.165 10.127 10.697 1.01 ± 0.02
head keccak_integration_benchmark 10.305 ± 0.114 10.204 10.572 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.523 ± 0.044 3.476 3.628 1.00
head linear_search 3.528 ± 0.037 3.496 3.624 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.494 ± 0.025 2.477 2.562 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 2.488 ± 0.024 2.470 2.553 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.295 ± 0.012 2.272 2.311 1.00
head math_integration_benchmark 2.314 ± 0.021 2.291 2.351 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.021 ± 0.055 1.988 2.175 1.00 ± 0.03
head memory_integration_benchmark 2.017 ± 0.006 2.009 2.029 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.284 ± 0.012 2.269 2.307 1.00
head operations_with_data_structures_benchmarks 2.302 ± 0.037 2.273 2.401 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 844.5 ± 2.9 839.7 848.6 1.00 ± 0.00
head pedersen 844.5 ± 2.7 841.0 848.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.576 ± 0.038 1.553 1.683 1.01 ± 0.03
head poseidon_integration_benchmark 1.567 ± 0.016 1.549 1.593 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.641 ± 0.012 2.627 2.666 1.00
head secp_integration_benchmark 2.662 ± 0.024 2.646 2.724 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.293 ± 0.008 1.277 1.301 1.00 ± 0.01
head set_integration_benchmark 1.292 ± 0.006 1.284 1.301 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 6.531 ± 0.073 6.458 6.722 1.00
head uint256_integration_benchmark 6.564 ± 0.039 6.516 6.646 1.01 ± 0.01

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1270 (9f7819f) into main (d332207) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   97.61%   97.60%   -0.01%     
==========================================
  Files          89       89              
  Lines       36333    36335       +2     
==========================================
  Hits        35466    35466              
- Misses        867      869       +2     
Impacted Files Coverage Δ
cairo-vm-cli/src/main.rs 96.15% <60.00%> (-1.51%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Show resolved Hide resolved
@matias-gonz matias-gonz added this pull request to the merge queue Jun 23, 2023
Merged via the queue into main with commit 8c7e1a2 Jun 23, 2023
29 of 31 checks passed
@matias-gonz matias-gonz deleted the fix_cli_error_message branch June 23, 2023 16:13
@fmoletta fmoletta mentioned this pull request Jun 23, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cairo-rs-cli raises with -h
3 participants