Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative offset error. #1271

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix negative offset error. #1271

merged 1 commit into from
Jun 22, 2023

Conversation

alonh5
Copy link
Collaborator

@alonh5 alonh5 commented Jun 22, 2023

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1271 (3fbd4f6) into main (1dbe08a) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main    #1271   +/-   ##
=======================================
  Coverage   97.60%   97.61%           
=======================================
  Files          89       89           
  Lines       36334    36333    -1     
=======================================
+ Hits        35464    35466    +2     
+ Misses        870      867    -3     
Impacted Files Coverage Δ
vm/src/types/relocatable.rs 99.85% <85.71%> (+0.44%) ⬆️
..._processor/builtin_hint_processor/blake2s_utils.rs 99.78% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Please add an entry to the changelog about the change. Something like:

* fix: change error returned when subtracting two `MaybeRelocatable`s to better reflect the cause

@alonh5 alonh5 force-pushed the alonh/fix_neg_offset_error branch from 662c7b9 to 3fbd4f6 Compare June 22, 2023 13:41
@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 13.039 ± 0.139 12.821 13.305 1.00 ± 0.01
head blake2s_integration_benchmark 13.005 ± 0.090 12.917 13.217 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.564 ± 0.063 4.505 4.705 1.00 ± 0.02
head compare_arrays_200000 4.541 ± 0.030 4.491 4.585 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.025 ± 0.018 2.994 3.056 1.00
head dict_integration_benchmark 3.026 ± 0.014 3.004 3.051 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.876 ± 0.013 4.849 4.890 1.00
head factorial_multirun 4.883 ± 0.021 4.854 4.919 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.083 ± 0.058 4.019 4.234 1.01 ± 0.02
head fibonacci_1000_multirun 4.054 ± 0.039 4.026 4.150 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 2.300 ± 0.046 2.274 2.427 1.00
head field_arithmetic_get_square_benchmark 2.309 ± 0.045 2.269 2.388 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 11.491 ± 0.229 11.261 12.047 1.00
head integration_builtins 11.614 ± 0.440 11.269 12.768 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 13.221 ± 0.138 13.055 13.422 1.01 ± 0.02
head keccak_integration_benchmark 13.110 ± 0.146 12.887 13.376 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.666 ± 0.114 4.559 4.892 1.02 ± 0.03
head linear_search 4.573 ± 0.019 4.546 4.605 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.235 ± 0.018 3.214 3.271 1.00
head math_cmp_and_pow_integration_benchmark 3.249 ± 0.012 3.229 3.267 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.016 ± 0.028 2.993 3.090 1.00
head math_integration_benchmark 3.018 ± 0.045 2.987 3.139 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.620 ± 0.027 2.582 2.686 1.00
head memory_integration_benchmark 2.645 ± 0.032 2.610 2.709 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.983 ± 0.032 2.936 3.057 1.00
head operations_with_data_structures_benchmarks 2.995 ± 0.018 2.965 3.013 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.047 ± 0.009 1.038 1.068 1.00 ± 0.01
head pedersen 1.047 ± 0.006 1.038 1.054 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.877 ± 0.019 1.861 1.916 1.00 ± 0.01
head poseidon_integration_benchmark 1.868 ± 0.006 1.860 1.878 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.585 ± 0.088 3.534 3.806 1.02 ± 0.03
head secp_integration_benchmark 3.532 ± 0.008 3.518 3.543 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.976 ± 0.008 1.962 1.987 1.00
head set_integration_benchmark 1.983 ± 0.012 1.967 2.013 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.350 ± 0.019 8.323 8.390 1.00
head uint256_integration_benchmark 8.357 ± 0.118 8.290 8.650 1.00 ± 0.01

@MegaRedHand MegaRedHand added this pull request to the merge queue Jun 22, 2023
Merged via the queue into main with commit d332207 Jun 22, 2023
30 of 31 checks passed
@MegaRedHand MegaRedHand deleted the alonh/fix_neg_offset_error branch June 22, 2023 14:43
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants