Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REDUCE_V2 hint #1420

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Add REDUCE_V2 hint #1420

merged 7 commits into from
Aug 28, 2023

Conversation

pefontana
Copy link
Member

@pefontana pefontana commented Aug 28, 2023

Add REDUCE_V2 hint

  • Implement REDUCE_V2 hint
  • Rename hint REDUCE -> REDUCE_V1

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@pefontana pefontana marked this pull request as ready for review August 28, 2023 17:54
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1420 (612c907) into main (4267138) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1420   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          94       94           
  Lines       38530    38582   +52     
=======================================
+ Hits        37571    37623   +52     
  Misses        959      959           
Files Changed Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 99.09% <100.00%> (+<0.01%) ⬆️
...ocessor/builtin_hint_processor/secp/field_utils.rs 99.73% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 3.926 ± 0.017 3.902 3.958 1.00
head big_factorial 3.944 ± 0.022 3.921 3.994 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.468 ± 0.020 3.454 3.523 1.00
head big_fibonacci 3.484 ± 0.025 3.459 3.544 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 10.206 ± 0.241 10.050 10.832 1.00
head blake2s_integration_benchmark 10.409 ± 0.539 10.102 11.854 1.02 ± 0.06
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.524 ± 0.028 3.492 3.571 1.00 ± 0.01
head compare_arrays_200000 3.509 ± 0.020 3.485 3.542 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.312 ± 0.016 2.296 2.353 1.00
head dict_integration_benchmark 2.321 ± 0.023 2.300 2.374 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.814 ± 0.022 1.798 1.874 1.00
head field_arithmetic_get_square_benchmark 1.826 ± 0.014 1.816 1.856 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 10.197 ± 0.133 10.085 10.481 1.00 ± 0.01
head integration_builtins 10.182 ± 0.042 10.138 10.271 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 10.265 ± 0.099 10.176 10.521 1.00
head keccak_integration_benchmark 10.389 ± 0.194 10.265 10.907 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.532 ± 0.020 3.515 3.584 1.00
head linear_search 3.542 ± 0.011 3.528 3.563 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.456 ± 0.015 2.434 2.490 1.00
head math_cmp_and_pow_integration_benchmark 2.457 ± 0.007 2.451 2.469 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.250 ± 0.008 2.238 2.260 1.00
head math_integration_benchmark 2.255 ± 0.007 2.248 2.270 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.003 ± 0.029 1.983 2.082 1.00 ± 0.02
head memory_integration_benchmark 2.000 ± 0.007 1.993 2.016 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.209 ± 0.011 2.192 2.232 1.00
head operations_with_data_structures_benchmarks 2.209 ± 0.008 2.201 2.231 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 855.2 ± 1.3 853.3 857.9 1.00
head pedersen 861.4 ± 3.0 857.3 866.1 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.544 ± 0.007 1.535 1.562 1.00
head poseidon_integration_benchmark 1.552 ± 0.013 1.537 1.581 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.690 ± 0.009 2.677 2.703 1.00
head secp_integration_benchmark 2.697 ± 0.014 2.678 2.728 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.301 ± 0.029 1.281 1.382 1.01 ± 0.02
head set_integration_benchmark 1.291 ± 0.003 1.287 1.296 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 6.465 ± 0.032 6.434 6.544 1.00
head uint256_integration_benchmark 6.481 ± 0.017 6.463 6.511 1.00 ± 0.01

@fmoletta fmoletta added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit 5f7a147 Aug 28, 2023
38 checks passed
@fmoletta fmoletta deleted the add-reduce-v2-hint branch August 28, 2023 20:04
Oppen pushed a commit that referenced this pull request Dec 7, 2023
This was referenced Dec 7, 2023
Oppen added a commit that referenced this pull request Dec 7, 2023
* Backport REDUCE_V2 hint (#1420)

* Release v0.8.2-hotfix1

* ci: run for all PRs

* ci: try to make some space

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants