Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update serialize memory for bin format #1447

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

drspacemn
Copy link
Contributor

@drspacemn drspacemn commented Sep 19, 2023

CairoPieMemory Serialization #1446

Description

Serialization of the CairoPieMemory trace to be handled in the binary format as the python VM here:

Byte serialization defined here:

Implementation options available here:

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@Oppen
Copy link
Member

Oppen commented Sep 21, 2023

Hey, very nice PR! The code itself looks great, but I need to check the references first to understand it better just in case :)

Copy link
Member

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked, so I can confidently approve :)
Just check the little u64 stuff.

@drspacemn
Copy link
Contributor Author

Okay swapped usize -> u64 and updated for WASM tests

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1447 (7a08b6d) into main (8d711e1) will decrease coverage by 0.01%.
The diff coverage is 95.77%.

@@            Coverage Diff             @@
##             main    #1447      +/-   ##
==========================================
- Coverage   96.99%   96.99%   -0.01%     
==========================================
  Files          93       93              
  Lines       38782    38773       -9     
==========================================
- Hits        37618    37606      -12     
- Misses       1164     1167       +3     
Files Coverage Δ
vm/src/vm/runners/cairo_pie.rs 96.59% <95.77%> (-2.12%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana added this pull request to the merge queue Sep 26, 2023
Merged via the queue into lambdaclass:main with commit fdf61bd Sep 26, 2023
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants