Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default program attributes to empty vec #1450

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

Oppen
Copy link
Member

@Oppen Oppen commented Sep 29, 2023

This allows removing a special case in SiR and is arguably more correct in general.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 3.720 ± 0.038 3.659 3.776 1.01 ± 0.02
head big_factorial 3.676 ± 0.044 3.609 3.740 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.166 ± 0.042 3.102 3.211 1.00 ± 0.02
head big_fibonacci 3.154 ± 0.044 3.076 3.222 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 9.072 ± 0.108 8.902 9.228 1.00
head blake2s_integration_benchmark 9.091 ± 0.085 8.943 9.271 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.240 ± 0.025 3.196 3.269 1.00 ± 0.01
head compare_arrays_200000 3.237 ± 0.028 3.173 3.267 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.216 ± 0.017 2.180 2.232 1.00 ± 0.01
head dict_integration_benchmark 2.209 ± 0.018 2.170 2.227 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.688 ± 0.008 1.672 1.699 1.00
head field_arithmetic_get_square_benchmark 1.723 ± 0.080 1.676 1.943 1.02 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.107 ± 0.131 8.943 9.365 1.00 ± 0.02
head integration_builtins 9.098 ± 0.074 9.021 9.259 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 9.188 ± 0.046 9.102 9.269 1.00
head keccak_integration_benchmark 9.254 ± 0.095 9.121 9.386 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.276 ± 0.026 3.236 3.321 1.00
head linear_search 3.276 ± 0.036 3.226 3.325 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.376 ± 0.058 2.261 2.467 1.00
head math_cmp_and_pow_integration_benchmark 2.382 ± 0.085 2.317 2.611 1.00 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.161 ± 0.019 2.136 2.193 1.03 ± 0.02
head math_integration_benchmark 2.107 ± 0.028 2.059 2.146 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.858 ± 0.025 1.815 1.896 1.00
head memory_integration_benchmark 1.876 ± 0.015 1.842 1.890 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.107 ± 0.014 2.079 2.131 1.01 ± 0.01
head operations_with_data_structures_benchmarks 2.096 ± 0.021 2.058 2.123 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 784.1 ± 6.1 777.1 797.0 1.00
head pedersen 785.0 ± 2.9 779.4 790.3 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.524 ± 0.029 1.493 1.599 1.00 ± 0.02
head poseidon_integration_benchmark 1.523 ± 0.011 1.498 1.534 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.585 ± 0.024 2.553 2.627 1.00 ± 0.02
head secp_integration_benchmark 2.577 ± 0.034 2.531 2.658 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.347 ± 0.017 1.324 1.389 1.00 ± 0.01
head set_integration_benchmark 1.343 ± 0.005 1.334 1.352 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 5.988 ± 0.042 5.919 6.054 1.01 ± 0.01
head uint256_integration_benchmark 5.936 ± 0.025 5.886 5.964 1.00

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #1450 (23e6644) into main (b6b7350) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1450   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files          93       93           
  Lines       38773    38791   +18     
=======================================
+ Hits        37606    37624   +18     
  Misses       1167     1167           
Files Coverage Δ
vm/src/serde/deserialize_program.rs 97.36% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen enabled auto-merge October 2, 2023 19:31
@Oppen Oppen added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit f6c7cb0 Oct 2, 2023
43 checks passed
@Oppen Oppen deleted the fix/default_for_no_attrs branch October 2, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants