Unpin cairo-vm version for cairo1-run crate #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…airo-vm into add-cairo1-running-example
…airo-vm into add-cairo1-running-example
… unpin-vm-for-cairo1-run-crate
juanbono
approved these changes
Oct 12, 2023
…for-cairo1-run-crate
pefontana
approved these changes
Oct 12, 2023
pefontana
reviewed
Oct 12, 2023
pefontana
reviewed
Oct 12, 2023
| casm_extend! {ctx, | ||
| [ap + 0] = [ap + offset] + 3, ap++; | ||
| } | ||
| // } else if let Some(Arg::Array(_)) = arg_iter.peek() { |
There was a problem hiding this comment.
Are we leaving this commented for a reason?
There was a problem hiding this comment.
Its the part that handles function arguments (which we are not using), I left it for future reference
pefontana
approved these changes
Oct 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #1455 +/- ##
==========================================
- Coverage 96.84% 96.82% -0.02%
==========================================
Files 94 94
Lines 39003 39215 +212
==========================================
+ Hits 37772 37970 +198
- Misses 1231 1245 +14
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpin cairo-vm version for cairo1-run crate
Description
Description of the pull request changes and motivation.
Checklist