Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cairo1-run: Update corelib version to 2.3.1 #1483

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

pefontana
Copy link
Member

@pefontana pefontana commented Nov 15, 2023

Update corelib version to 2.3.1

Update corelib version to 2.3.1 in the Makefile

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@pefontana pefontana marked this pull request as ready for review November 15, 2023 15:58
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62e2e94) 96.82% compared to head (6bcbe39) 96.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1483   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files          95       95           
  Lines       39451    39451           
=======================================
  Hits        38199    38199           
  Misses       1252     1252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.553 ± 0.022 2.533 2.597 1.00 ± 0.01
head big_factorial 2.545 ± 0.015 2.518 2.568 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.192 ± 0.022 2.160 2.238 1.02 ± 0.01
head big_fibonacci 2.148 ± 0.015 2.123 2.170 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 5.922 ± 0.037 5.872 6.002 1.00
head blake2s_integration_benchmark 5.984 ± 0.055 5.939 6.125 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.270 ± 0.045 2.218 2.350 1.00 ± 0.02
head compare_arrays_200000 2.260 ± 0.022 2.238 2.304 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.578 ± 0.009 1.560 1.596 1.00
head dict_integration_benchmark 1.587 ± 0.008 1.574 1.600 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.050 ± 0.007 1.038 1.059 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.044 ± 0.007 1.033 1.055 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 6.022 ± 0.123 5.945 6.250 1.01 ± 0.02
head integration_builtins 5.969 ± 0.027 5.923 6.008 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 6.055 ± 0.043 6.004 6.119 1.00 ± 0.01
head keccak_integration_benchmark 6.037 ± 0.026 5.991 6.079 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.305 ± 0.016 2.290 2.341 1.00
head linear_search 2.309 ± 0.012 2.292 2.331 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.574 ± 0.016 1.544 1.605 1.00
head math_cmp_and_pow_integration_benchmark 1.577 ± 0.008 1.564 1.591 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.486 ± 0.007 1.475 1.500 1.00 ± 0.01
head math_integration_benchmark 1.482 ± 0.007 1.467 1.490 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.320 ± 0.009 1.309 1.336 1.01 ± 0.01
head memory_integration_benchmark 1.304 ± 0.008 1.290 1.316 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.441 ± 0.009 1.429 1.455 1.00
head operations_with_data_structures_benchmarks 1.441 ± 0.011 1.426 1.464 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 585.4 ± 14.7 576.6 626.3 1.01 ± 0.03
head pedersen 579.4 ± 2.2 575.8 582.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.175 ± 0.007 1.168 1.192 1.01 ± 0.01
head poseidon_integration_benchmark 1.160 ± 0.005 1.154 1.168 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.018 ± 0.019 1.999 2.062 1.01 ± 0.01
head secp_integration_benchmark 2.005 ± 0.008 1.994 2.023 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.158 ± 0.008 1.150 1.175 1.00
head set_integration_benchmark 1.161 ± 0.018 1.147 1.207 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.812 ± 0.024 3.777 3.859 1.00
head uint256_integration_benchmark 3.813 ± 0.015 3.790 3.837 1.00 ± 0.01

@Oppen Oppen added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit e61ae17 Nov 15, 2023
51 checks passed
@Oppen Oppen deleted the cairo-1-update-core-lib branch November 15, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants