Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix to cancel duplicate workflow file #1497

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Nov 27, 2023

Fix workflow error

Description

Fixes a small issue in the cancel-duplicate workflow file. The cancellation of the bench workflow is not needed for bench_pull_request anymore since this was removed. Not sure if you want to add the hyperfine workflow to it, let me know.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8887e60) 96.82% compared to head (b544c5e) 96.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1497   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files          96       96           
  Lines       39684    39684           
=======================================
  Hits        38423    38423           
  Misses       1261     1261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Oppen
Copy link
Member

Oppen commented Nov 27, 2023

I seem to recall this workaround is not even needed anymore: I believe concurrency is meant to handle cancellation these days.

@greged93
Copy link
Contributor Author

greged93 commented Nov 27, 2023

ah true, I can just remove it then.

@Oppen
Copy link
Member

Oppen commented Nov 27, 2023

We would need to check the concurrency settings in the other workflows before removing the whole cancel workflow.

@greged93
Copy link
Contributor Author

so right now, this workflow was cancelling the runs for rust and bench_pull_request workflows in case of duplicates. bench_pull_request was removed, I can add concurrency settings to the rust workflow. Would that work?

@Oppen
Copy link
Member

Oppen commented Nov 30, 2023

I think that would work, yes.

CHANGELOG.md Show resolved Hide resolved
@Oppen Oppen added this pull request to the merge queue Dec 4, 2023
Merged via the queue into lambdaclass:main with commit db708e3 Dec 4, 2023
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants