Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proof_mode flag to cairo1-run #1537

Merged
merged 8 commits into from
Jan 15, 2024
Merged

Add proof_mode flag to cairo1-run #1537

merged 8 commits into from
Jan 15, 2024

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Jan 3, 2024

Closes #1528
Allows cairo1-run to run both proof_mode and non proof_mode

@fmoletta fmoletta marked this pull request as ready for review January 3, 2024 20:33
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b9aabe) 97.21% compared to head (29d125d) 97.21%.

Files Patch % Lines
cairo1-run/src/main.rs 98.24% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
- Coverage   97.21%   97.21%   -0.01%     
==========================================
  Files          90       90              
  Lines       36452    36471      +19     
==========================================
+ Hits        35437    35455      +18     
- Misses       1015     1016       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 3, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.148 ± 0.016 2.133 2.187 1.00
head big_factorial 2.163 ± 0.013 2.151 2.186 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.146 ± 0.025 2.117 2.181 1.01 ± 0.02
head big_fibonacci 2.123 ± 0.026 2.081 2.157 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.823 ± 0.054 7.722 7.894 1.00 ± 0.01
head blake2s_integration_benchmark 7.795 ± 0.048 7.725 7.849 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.196 ± 0.015 2.176 2.231 1.00
head compare_arrays_200000 2.209 ± 0.020 2.187 2.256 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.397 ± 0.007 1.385 1.408 1.00
head dict_integration_benchmark 1.399 ± 0.011 1.388 1.427 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.238 ± 0.007 1.226 1.247 1.00
head field_arithmetic_get_square_benchmark 1.242 ± 0.011 1.225 1.263 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.898 ± 0.179 7.776 8.392 1.01 ± 0.02
head integration_builtins 7.849 ± 0.056 7.784 7.929 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.140 ± 0.061 8.046 8.239 1.00
head keccak_integration_benchmark 8.141 ± 0.159 7.980 8.551 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.228 ± 0.025 2.200 2.263 1.00
head linear_search 2.232 ± 0.022 2.215 2.291 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.538 ± 0.008 1.528 1.551 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.525 ± 0.004 1.520 1.536 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.409 ± 0.011 1.396 1.427 1.00 ± 0.01
head math_integration_benchmark 1.407 ± 0.018 1.387 1.436 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.226 ± 0.009 1.217 1.240 1.00 ± 0.01
head memory_integration_benchmark 1.220 ± 0.008 1.209 1.230 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.579 ± 0.005 1.571 1.586 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.574 ± 0.011 1.560 1.597 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 599.1 ± 3.0 595.0 602.9 1.00
head pedersen 599.6 ± 2.2 595.3 601.9 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.063 ± 0.003 1.061 1.069 1.00
head poseidon_integration_benchmark 1.066 ± 0.003 1.061 1.071 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.888 ± 0.008 1.879 1.905 1.00
head secp_integration_benchmark 1.895 ± 0.007 1.883 1.903 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 763.4 ± 2.8 756.8 766.6 1.00
head set_integration_benchmark 763.6 ± 2.5 759.8 768.0 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.405 ± 0.031 4.373 4.452 1.00 ± 0.01
head uint256_integration_benchmark 4.392 ± 0.040 4.342 4.456 1.00

Oppen
Oppen previously approved these changes Jan 11, 2024
@Oppen Oppen enabled auto-merge January 15, 2024 15:33
@Oppen Oppen added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit 9fc9c6e Jan 15, 2024
50 checks passed
@Oppen Oppen deleted the cairo1-run-proof-arg branch January 15, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cairo1-run] Enable not proof mode run
3 participants