-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor cairo1-run crate #1601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto different functions
Benchmark Results for unmodified programs 🚀
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
- Coverage 97.16% 97.13% -0.03%
==========================================
Files 91 92 +1
Lines 37326 37347 +21
==========================================
+ Hits 36266 36276 +10
- Misses 1060 1071 +11 ☔ View full report in Codecov by Sentry. |
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono and
pefontana
as code owners
February 6, 2024 16:54
igaray
previously approved these changes
Feb 6, 2024
juanbono
approved these changes
Feb 7, 2024
igaray
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two refactors:
Creating a
cairo_run
function that executes a sierra program and returns the runner, vm and return values (Similar to cairo_vm's cairo_run function) and using it in therun
function. Therun
function now only contains code related to compiling the sierra program, serializing the program output & fetching and writing outputs into files.Refactoring the new
cairo_run
function's code into different functions for each step of the process instead of the current monolithic block of code