Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Starknet -types-core dep #1628

Merged
merged 2 commits into from
Feb 22, 2024
Merged

bump Starknet -types-core dep #1628

merged 2 commits into from
Feb 22, 2024

Conversation

pefontana
Copy link
Member

@pefontana pefontana commented Feb 22, 2024

bump Starknet -types-core dep

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@pefontana pefontana marked this pull request as ready for review February 22, 2024 19:58
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (59254f4) to head (57740f9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1628   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          91       91           
  Lines       37393    37393           
=======================================
  Hits        36523    36523           
  Misses        870      870           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Oppen Oppen enabled auto-merge February 22, 2024 20:17
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.315 ± 0.019 2.285 2.338 1.00
head big_factorial 2.321 ± 0.057 2.279 2.469 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.325 ± 0.026 2.296 2.369 1.03 ± 0.01
head big_fibonacci 2.259 ± 0.013 2.240 2.280 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.701 ± 0.320 8.503 9.558 1.01 ± 0.04
head blake2s_integration_benchmark 8.633 ± 0.110 8.501 8.740 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.372 ± 0.020 2.347 2.409 1.00
head compare_arrays_200000 2.386 ± 0.012 2.360 2.405 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.470 ± 0.024 1.451 1.531 1.00
head dict_integration_benchmark 1.483 ± 0.031 1.461 1.554 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.396 ± 0.003 1.392 1.403 1.00 ± 0.00
head field_arithmetic_get_square_benchmark 1.390 ± 0.005 1.382 1.400 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.612 ± 0.121 8.484 8.840 1.00
head integration_builtins 8.675 ± 0.231 8.472 9.283 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.818 ± 0.113 8.693 8.962 1.00 ± 0.02
head keccak_integration_benchmark 8.806 ± 0.136 8.679 9.007 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.385 ± 0.027 2.354 2.438 1.01 ± 0.02
head linear_search 2.373 ± 0.024 2.346 2.427 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.836 ± 0.022 1.811 1.880 1.01 ± 0.02
head math_cmp_and_pow_integration_benchmark 1.826 ± 0.019 1.807 1.855 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.613 ± 0.019 1.589 1.636 1.00
head math_integration_benchmark 1.625 ± 0.031 1.596 1.707 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.300 ± 0.036 1.268 1.387 1.01 ± 0.03
head memory_integration_benchmark 1.290 ± 0.022 1.271 1.337 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.917 ± 0.015 1.903 1.954 1.00
head operations_with_data_structures_benchmarks 1.918 ± 0.021 1.897 1.970 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 600.9 ± 5.9 594.4 613.9 1.01 ± 0.01
head pedersen 593.5 ± 2.2 591.1 597.0 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 978.1 ± 9.0 966.3 994.3 1.01 ± 0.01
head poseidon_integration_benchmark 972.4 ± 5.9 963.8 982.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.932 ± 0.004 1.926 1.938 1.00 ± 0.01
head secp_integration_benchmark 1.931 ± 0.020 1.920 1.988 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 732.1 ± 2.1 730.9 737.8 1.01 ± 0.01
head set_integration_benchmark 727.9 ± 3.7 722.0 733.6 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.756 ± 0.107 4.677 5.049 1.02 ± 0.03
head uint256_integration_benchmark 4.678 ± 0.051 4.641 4.779 1.00

@Oppen Oppen added this pull request to the merge queue Feb 22, 2024
@pefontana pefontana removed this pull request from the merge queue due to a manual request Feb 22, 2024
@pefontana pefontana added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit 2a8e0a3 Feb 22, 2024
52 checks passed
@pefontana pefontana deleted the bump-starknet-types-cope branch February 22, 2024 21:13
@pefontana pefontana linked an issue Feb 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump starknet-types-core version to 0.0.9
4 participants