-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cairo 1] Add flag to append return values to output segment when not running in proof_mode #1646
Conversation
Benchmark Results for unmodified programs 🚀
|
append_return_values
to output segment when not running in proof_mode
append_return_values
to output segment when not running in proof_modeappend_return_values
to output segment when not running in proof_mode
append_return_values
to output segment when not running in proof_mode
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
==========================================
- Coverage 97.65% 97.64% -0.01%
==========================================
Files 92 92
Lines 37619 37656 +37
==========================================
+ Hits 36735 36769 +34
- Misses 884 887 +3 ☔ View full report in Codecov by Sentry. |
// Create specific instructions to append the return values to the output segment when not running in proof_mode | ||
// Call the firt program instruction, appends the return values to the output builtin's memory segment and then returns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is intended to be the documentation, then it should be prefixed with the triple slash ///
.
append_return_values
to both the CLI andCairo1RunConfig
struct.