Feature: output builtin add_attribute method
#1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
Problem: some OS hints need to add attributes to the output builtin. The Python implementation defines an `add_attribute` method that is not present in `cairo-vm`. Solution: port the `add_attribute` method.
odesenfans
force-pushed
the
msl/output-builtin-add-attribute
branch
from
afa0bdb
to
4add641
Compare
juanbono
approved these changes
Apr 3, 2024
fmoletta
approved these changes
Apr 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 95 95
Lines 38409 38422 +13
=======================================
+ Hits 37090 37103 +13
Misses 1319 1319 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: some OS hints need to add attributes to the output builtin. The Python implementation defines an
add_attributemethod that is not present incairo-vm.Solution: port the
add_attributemethod.Description of the pull request changes and motivation.
Checklist