Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump starknet-types-core version + Use the lib's pedersen hash #1692

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Apr 3, 2024

  • Bumps starknet-types-core to version 0.1.0
  • Uses starknet-types-core's pedersen hash for the HashBuiltinRunner

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (6ff8126) to head (24535c9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1692   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          98       98           
  Lines       38102    38092   -10     
=======================================
- Hits        36160    36151    -9     
+ Misses       1942     1941    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 4, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.290 ± 0.030 2.268 2.367 1.00
head big_factorial 2.293 ± 0.029 2.272 2.349 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.288 ± 0.033 2.253 2.371 1.00
head big_fibonacci 2.307 ± 0.041 2.265 2.391 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.581 ± 0.185 8.326 8.771 1.00
head blake2s_integration_benchmark 8.746 ± 0.288 8.349 9.334 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.356 ± 0.014 2.334 2.378 1.00 ± 0.01
head compare_arrays_200000 2.349 ± 0.014 2.323 2.370 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.476 ± 0.010 1.462 1.495 1.01 ± 0.01
head dict_integration_benchmark 1.467 ± 0.011 1.451 1.486 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.316 ± 0.011 1.297 1.327 1.00
head field_arithmetic_get_square_benchmark 1.408 ± 0.043 1.379 1.525 1.07 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.525 ± 0.178 8.325 8.731 1.00
head integration_builtins 8.534 ± 0.185 8.332 8.733 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.768 ± 0.200 8.563 8.982 1.00
head keccak_integration_benchmark 8.918 ± 0.299 8.591 9.601 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.357 ± 0.022 2.337 2.394 1.00
head linear_search 2.379 ± 0.032 2.342 2.437 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.596 ± 0.014 1.577 1.619 1.00
head math_cmp_and_pow_integration_benchmark 1.857 ± 0.037 1.825 1.957 1.16 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.447 ± 0.014 1.426 1.468 1.00
head math_integration_benchmark 1.630 ± 0.025 1.604 1.672 1.13 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.286 ± 0.019 1.263 1.330 1.00
head memory_integration_benchmark 1.287 ± 0.021 1.262 1.314 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.618 ± 0.013 1.605 1.651 1.00
head operations_with_data_structures_benchmarks 1.918 ± 0.013 1.900 1.944 1.19 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 589.9 ± 1.5 586.6 591.3 1.08 ± 0.00
head pedersen 548.1 ± 1.3 546.6 550.6 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 974.4 ± 4.9 968.1 984.9 1.00
head poseidon_integration_benchmark 981.4 ± 7.0 973.3 990.5 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.872 ± 0.011 1.858 1.891 1.00
head secp_integration_benchmark 1.926 ± 0.022 1.907 1.983 1.03 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 749.5 ± 7.6 743.0 768.8 1.00 ± 0.01
head set_integration_benchmark 747.7 ± 3.0 745.4 755.7 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.726 ± 0.086 4.600 4.877 1.01 ± 0.02
head uint256_integration_benchmark 4.662 ± 0.050 4.607 4.725 1.00

@fmoletta fmoletta marked this pull request as ready for review April 4, 2024 14:35
@fmoletta fmoletta added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@fmoletta fmoletta added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit e629428 Apr 16, 2024
70 checks passed
@fmoletta fmoletta deleted the bump-core-types-use-pedersen branch April 16, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants