Fixed CairoPie output builtin data deserlialization. #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alon-Ti
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
fmoletta
reviewed
Jun 3, 2024
Alon-Ti
force-pushed
the
cairo-pie-output-deserialize
branch
from
19dc39b
to
38ba496
Compare
juanbono
approved these changes
Jun 4, 2024
|
Thanks! Can you add a short description of the changes to the CHANGELOG? |
Alon-Ti
force-pushed
the
cairo-pie-output-deserialize
branch
from
38ba496
to
393488f
Compare
Alon-Ti
force-pushed
the
cairo-pie-output-deserialize
branch
from
393488f
to
50efe20
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
- Coverage 94.82% 94.78% -0.04%
==========================================
Files 102 102
Lines 40086 40122 +36
==========================================
+ Hits 38010 38031 +21
- Misses 2076 2091 +15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public memory pages were deserialized as structs, whereas CairoPies have them as JSON arrays of length 2.