Add ExecutionResources multiplication #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pefontana
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
Juan-M-V
as code owners
Codecov Report
@@ Coverage Diff @@
## main #908 +/- ##
=======================================
Coverage 97.38% 97.39%
=======================================
Files 69 69
Lines 29217 29279 +62
=======================================
+ Hits 28454 28516 +62
Misses 763 763
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fmoletta
reviewed
Mar 17, 2023
A pleasure to comeback |
Oppen
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ExecutionResources multiplication
We need
ExecutionResources * u64implementation in starknet_in_rusthttps://github.com/starkware-libs/cairo-lang/blob/master/src/starkware/starknet/business_logic/execution/os_usage.py#L37
Checklist