Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only relocate memory if memory_file is passed #910

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Only relocate memory if memory_file is passed #910

merged 4 commits into from
Mar 28, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Mar 17, 2023

This PR aims to avoid relocating the cairo memory if its not going to be outputted by the vm. If using the cairo_run, this can be customized via the CairoRunConfig

@fmoletta fmoletta changed the title Only relocate memory if memory_file is passed Only relocate memory if memory_file is passed Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #910 (e55ab79) into main (77fe09e) will decrease coverage by 0.01%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   97.41%   97.41%   -0.01%     
==========================================
  Files          70       70              
  Lines       29641    29652      +11     
==========================================
+ Hits        28876    28886      +10     
- Misses        765      766       +1     
Impacted Files Coverage Δ
cairo-vm-cli/src/main.rs 26.31% <0.00%> (-0.28%) ⬇️
src/vm/runners/cairo_runner.rs 97.72% <91.66%> (+<0.01%) ⬆️
src/cairo_run.rs 98.52% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmoletta fmoletta marked this pull request as ready for review March 23, 2023 18:29
@juanbono juanbono added this pull request to the merge queue Mar 28, 2023
Merged via the queue into main with commit d5824b8 Mar 28, 2023
@juanbono juanbono deleted the dont-relocate branch March 28, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants