Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline to enforce updating CHANGELOG.md #962

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

Oppen
Copy link
Member

@Oppen Oppen commented Apr 12, 2023

As we've been failing to keep this critical documentation up-to-date, this acts as a strong reminder that it should be updated by failing the checks on every PR lacking this update.
It includes the exception for the labels "pipelines" and "coverage", as PRs that only work on those don't introduce user-visible changes.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

As we've been failing to keep this critical documentation up-to-date,
this acts as a strong reminder that it should be updated by failing the
checks on every PR lacking this update.
It includes the exception for the labels "pipelines" and "coverage", as
PRs that only work on those don't introduce user-visible changes.
@Oppen Oppen added the pipelines This PR/issue is exclusively about improving our CI label Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #962 (f42b294) into main (5fab4cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files          74       74           
  Lines       30392    30392           
=======================================
  Hits        29708    29708           
  Misses        684      684           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana added this pull request to the merge queue Apr 12, 2023
Merged via the queue into main with commit a1a65fd Apr 12, 2023
@pefontana pefontana deleted the simple_changelog_enforcement branch April 12, 2023 21:32
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
As we've been failing to keep this critical documentation up-to-date,
this acts as a strong reminder that it should be updated by failing the
checks on every PR lacking this update.
It includes the exception for the labels "pipelines" and "coverage", as
PRs that only work on those don't introduce user-visible changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants