feat: re-export felt crate from cairo_vm #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 75 75
Lines 31155 31155
=======================================
Hits 30459 30459
Misses 696 696
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
requested review from
igaray,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
Oppen
changed the title
Oppen
changed the title
MegaRedHand
approved these changes
Apr 13, 2023
juanbono
approved these changes
Apr 17, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Re-export felt crate from cairo_vm to avoid version mismatches * Update CHANGELOG * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-exports as
pub extern cratethe importedcairo-felt. It's a public dependency (types defined by it are part of the public APIs) and requiring explicit imports causes issues where the version imported by downstream does not match the one imported bycairo-vm, which ends up in compilation failures.After this change the users have the option of importing
cairo-vmonly and usecairo_vm::felt::Felt252to get the exact version of the type used by the VM crate, eliminating such errors.This is not a breaking change.
Checklist