Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hints): add NewHint#30 #984

Merged
merged 9 commits into from
Apr 14, 2023
Merged

feat(hints): add NewHint#30 #984

merged 9 commits into from
Apr 14, 2023

Conversation

MegaRedHand
Copy link
Contributor

@MegaRedHand MegaRedHand commented Apr 13, 2023

TITLE

Description

This PR adds the missing hint NewHint#30, now known as COMPUTE_SLOPE_WHITELIST.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@MegaRedHand MegaRedHand added the whitelisted-hint Implementation of hint on whitelist directory label Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #984 (0f2f7bc) into main (a36797f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #984   +/-   ##
=======================================
  Coverage   97.75%   97.76%           
=======================================
  Files          75       75           
  Lines       31035    31093   +58     
=======================================
+ Hits        30339    30397   +58     
  Misses        696      696           
Impacted Files Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 98.72% <100.00%> (+0.02%) ⬆️
..._processor/builtin_hint_processor/secp/ec_utils.rs 99.42% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a small suggestion :)

Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com>
@Oppen Oppen enabled auto-merge April 14, 2023 16:19
@Oppen Oppen added this pull request to the merge queue Apr 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 14, 2023
@Oppen Oppen added this pull request to the merge queue Apr 14, 2023
Merged via the queue into main with commit b5ae251 Apr 14, 2023
9 checks passed
@Oppen Oppen deleted the newhint30-compute-slope branch April 14, 2023 22:18
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Add `COMPUTE_SLOPE_WHITELIST` hint

* Update changelog

* Fix: add missing return to cairo program

* Separate changelog item and description

Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com>

* Format

---------

Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com>
Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whitelisted-hint Implementation of hint on whitelist directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants