Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hints): add NewHint#27 #990

Merged
merged 6 commits into from
Apr 17, 2023
Merged

feat(hints): add NewHint#27 #990

merged 6 commits into from
Apr 17, 2023

Conversation

MegaRedHand
Copy link
Contributor

@MegaRedHand MegaRedHand commented Apr 14, 2023

Description

Depends: #989

This PR adds the missing hint NewHint#27, now known as EC_DOUBLE_ASSIGN_NEW_X_V2. It also renames EC_DOUBLE_ASSIGN_NEW_X to EC_DOUBLE_ASSIGN_NEW_X_V1.

@pefontana pefontana added the whitelisted-hint Implementation of hint on whitelist directory label Apr 14, 2023
@MegaRedHand MegaRedHand force-pushed the newhint27-ec-double-assign-new-x branch from 610f170 to 741a208 Compare April 14, 2023 20:31
Base automatically changed from newhint28-verify-zero to main April 15, 2023 04:49
Some of the entries were being repeated when merging changes, and were also originally misplaced in the 0.3.0-rc1 section
@MegaRedHand MegaRedHand force-pushed the newhint27-ec-double-assign-new-x branch from 741a208 to 6a5aede Compare April 15, 2023 14:28
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #990 (230bfa2) into main (8e24668) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   97.76%   97.76%   -0.01%     
==========================================
  Files          75       75              
  Lines       31155    31154       -1     
==========================================
- Hits        30459    30458       -1     
  Misses        696      696              
Impacted Files Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 98.75% <100.00%> (ø)
..._processor/builtin_hint_processor/secp/ec_utils.rs 99.46% <100.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen enabled auto-merge April 17, 2023 14:57
@Oppen Oppen added this pull request to the merge queue Apr 17, 2023
Merged via the queue into main with commit ddbeb8a Apr 17, 2023
13 checks passed
@Oppen Oppen deleted the newhint27-ec-double-assign-new-x branch April 17, 2023 15:46
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Add NewHint#27

* Update changelog

* Fix changelog

Some of the entries were being repeated when merging changes, and were also originally misplaced in the 0.3.0-rc1 section

* Make hint codes public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whitelisted-hint Implementation of hint on whitelist directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants