Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing \n character in traceback string #997

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Add missing \n character in traceback string #997

merged 4 commits into from
Apr 17, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Apr 17, 2023

The \n character is missing after each traceback line when the filename is unknown

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@fmoletta fmoletta changed the title Add missing \n character in traceback string Add missing\n character in traceback string Apr 17, 2023
@fmoletta fmoletta changed the title Add missing\n character in traceback string Add missing \n character in traceback string Apr 17, 2023
@fmoletta fmoletta marked this pull request as ready for review April 17, 2023 14:26
@Oppen Oppen enabled auto-merge April 17, 2023 14:45
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #997 (c975878) into main (8e24668) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #997   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          75       75           
  Lines       31155    31155           
=======================================
  Hits        30459    30459           
  Misses        696      696           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen added this pull request to the merge queue Apr 17, 2023
Merged via the queue into main with commit 2f557b1 Apr 17, 2023
13 checks passed
@Oppen Oppen deleted the fix-traceback-str branch April 17, 2023 15:32
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Add missing \n character

* Add changelog entry

---------

Co-authored-by: Juan Bono <juanbono94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants