Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement enum_snapshot_match libfunc #366

Merged
merged 10 commits into from
Dec 12, 2023
Merged

Implement enum_snapshot_match libfunc #366

merged 10 commits into from
Dec 12, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Dec 11, 2023

  • Implement enum_snapshot_match libfunc
  • Add EnumSnapshotVariantsMeta mapping enum snapshot types to its variant's types
  • Add two integration tests running programs using enum_snapshot_match libfunc

Copy link

github-actions bot commented Dec 11, 2023

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.773 ± 0.095 20.674 21.018 42.73 ± 0.21
cairo-native (JIT MLIR ORC Engine) 1.561 ± 0.009 1.546 1.577 3.21 ± 0.02
cairo-native (AOT Native binary) 0.660 ± 0.001 0.659 0.662 1.36 ± 0.00
cairo-native (AOT Native binary with host CPU features, march=native) 0.486 ± 0.001 0.485 0.488 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.450 ± 0.480 20.169 21.779 647.27 ± 16.98
cairo-native (JIT MLIR ORC Engine) 1.216 ± 0.010 1.199 1.232 38.48 ± 0.55
cairo-native (AOT Native binary) 0.032 ± 0.000 0.031 0.032 1.00
cairo-native (AOT Native binary with host CPU features, march=native) 0.032 ± 0.002 0.031 0.053 1.01 ± 0.07

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.990 ± 0.024 1.941 2.018 28.37 ± 0.36
cairo-native (JIT MLIR ORC Engine) 1.499 ± 0.014 1.470 1.522 21.37 ± 0.21
cairo-native (AOT Native binary) 0.110 ± 0.000 0.109 0.110 1.56 ± 0.01
cairo-native (AOT Native binary with host CPU features, march=native) 0.070 ± 0.000 0.070 0.072 1.00

@fmoletta fmoletta marked this pull request as ready for review December 11, 2023 15:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (92c2801) 73.90% compared to head (f4cd504) 74.08%.

❗ Current head f4cd504 differs from pull request most recent head caaf430. Consider uploading reports for the commit caaf430 to get more accurate results

Files Patch % Lines
src/libfuncs/enum.rs 99.25% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   73.90%   74.08%   +0.17%     
==========================================
  Files          97       98       +1     
  Lines       22153    22300     +147     
==========================================
+ Hits        16372    16520     +148     
+ Misses       5781     5780       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmoletta fmoletta mentioned this pull request Dec 11, 2023
4 tasks
@edg-l edg-l merged commit 68d777c into main Dec 12, 2023
7 checks passed
@edg-l edg-l deleted the enum_snapshot_match branch December 12, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants