Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt backend messages in the client #1150

Closed
wants to merge 114 commits into from
Closed

Adapt backend messages in the client #1150

wants to merge 114 commits into from

Conversation

ncontinanza
Copy link
Contributor

Closes #[issue]

Motivation

Explain why not how.

Summary of changes

List changes in code.

How has this been tested?

Describe the steps you performed to test this PR.

Test additions / changes

List tests added/updated.

Checklist

  • I have tested the changes locally.
  • I self-reviewed the changes on GitHub, line by line.
  • Tests have been added/updated.
  • This change requires new documentation.
    • Documentation has been added/updated.
  • I have tested the changes in another devices.
    • Tested in iOS.
    • Tested in Android.

ncontinanza and others added 30 commits October 26, 2023 17:00
@ncontinanza
Game protobuf
6405d1e
@ncontinanza
Character
7c9f542
@ncontinanza
Skill
77ca0bd
@ncontinanza
Change durations to MillisTime
f679ea1
@BertovDev
Add Projectile and Loot proto messages
6b53d52
@BertovDev
Merge branch 'gh-748-new-config-protobuf' of github.com:lambdaclass/d…
5f5c7d6 
…ark_worlds_server into gh-748-new-config-protobuf
@ncontinanza
MillisTime message
47f0d12
@ncontinanza
Merge branch 'gh-748-new-config-protobuf' of github.com:lambdaclass/c…
6322804 
…urse_of_myrra into gh-748-new-config-protobuf
@BertovDev
Add effect message
c5fa156
@BertovDev
Merge branch 'gh-748-new-config-protobuf' of github.com:lambdaclass/d…
0064000 
…ark_worlds_server into gh-748-new-config-protobuf
@ncontinanza
Minor details
b904841
@ncontinanza
Represent lists of effects as strings
18b8277
@BertovDev
Add GameState proto message
2551e7f
@Nico-Sanchez
Add new join lobby endpoint
899c574
@Nico-Sanchez
Refactor MatchingSession, Runner and EngineRunner behavior.
bfb08fa 
EngineRunner were initialized indirectly by the old Runner.
Matching session will now launch the game after the given time
without waiting for a client trigger.
@Nico-Sanchez
Send the old config needed by the client from the server
06fd39b
@Nico-Sanchez
Add new start game trigger when the lobby is full
6338ef0
@ncontinanza
New messages and docs
b42b15a
@tvillegas98
Merge branch 'main' into gh-956-refactor-current-game-flow
2d6cca9
@ncontinanza
config message and separate actions in another .proto file
d3b6e26
@ncontinanza
Merge branch 'main' of github.com:lambdaclass/curse_of_myrra into gh-748
ecec31f 
-new-config-protobuf
@ncontinanza
Naming refactor
b71163b
@ncontinanza
Use new actions for movement and skills
2455f31
@ncontinanza
WIP: move protobuf files location
d7047f1
@manucamejo
Merge branch 'main' into gh-956-refactor-current-game-flow
94ca20a
@manucamejo
Merge branch 'gh-748-new-config-protobuf' into new-flow-01-11
609922f
@manucamejo
protofixes
8c2f659
@tvillegas98
Merge branch 'main' into new-flow-01-11
eb7b6c8
@tvillegas98
WIP commit. Creating engine runner when connecting to play_websocket
dc7e662
@tvillegas98
WIP commit. Make the game 'work'
bb25ea1
Base automatically changed from new-flow-01-11 to main November 17, 2023 18:29
@AminArria
Copy link
Contributor

Replaced by #1266

@AminArria AminArria closed this Dec 18, 2023
@AminArria AminArria deleted the adapt-backend-messages-in-the-client branch December 18, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AminArria AminArria Awaiting requested review from AminArria AminArria will be requested when the pull request is marked ready for review AminArria is a code owner

@manucamejo manucamejo Awaiting requested review from manucamejo manucamejo will be requested when the pull request is marked ready for review manucamejo is a code owner

@tvillegas98 tvillegas98 Awaiting requested review from tvillegas98 tvillegas98 will be requested when the pull request is marked ready for review tvillegas98 is a code owner

@martinacantaro martinacantaro Awaiting requested review from martinacantaro martinacantaro will be requested when the pull request is marked ready for review martinacantaro is a code owner

@mgrunwaldt mgrunwaldt Awaiting requested review from mgrunwaldt mgrunwaldt will be requested when the pull request is marked ready for review mgrunwaldt is a code owner

@saugon saugon Awaiting requested review from saugon saugon will be requested when the pull request is marked ready for review saugon is a code owner

@marco-paulucci marco-paulucci Awaiting requested review from marco-paulucci marco-paulucci will be requested when the pull request is marked ready for review marco-paulucci is a code owner

@agustinesco agustinesco Awaiting requested review from agustinesco agustinesco will be requested when the pull request is marked ready for review agustinesco is a code owner

@tkz00 tkz00 Awaiting requested review from tkz00 tkz00 will be requested when the pull request is marked ready for review tkz00 is a code owner

@Nico-Sanchez Nico-Sanchez Awaiting requested review from Nico-Sanchez Nico-Sanchez will be requested when the pull request is marked ready for review Nico-Sanchez is a code owner

@AngieDutra AngieDutra Awaiting requested review from AngieDutra AngieDutra will be requested when the pull request is marked ready for review AngieDutra is a code owner

@alfopisano alfopisano Awaiting requested review from alfopisano alfopisano will be requested when the pull request is marked ready for review alfopisano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ncontinanza @AminArria @BertovDev @Nico-Sanchez @tvillegas98 @manucamejo @axlrott @AngieDutra