Buttons fixes

[AngieDutra]

Motivation

Buttons in Battle.unity were broken:

• Exit buttons (in settings and death splash)
• Settings button
• Toggles:
  • Client prediction
  • Client prediction ghost
  • Interpolation

Summary of changes

This PR fixes all the buttons listed before. However I recommend the reviewer goes though all the buttons in that scene to check none were broken in the process.
Changes in Battle.unity were necessary since the prefab override, vital for the buttons to work again, implied changes in that scene. Also some references in the scene were missing so adding those also implied changes there.

Checklist

• I have tested the changes locally.
• I self-reviewed the changes on GitHub, line by line.
• Tests have been added/updated.
• This change requires new documentation.
  • Documentation has been added/updated.
• I have tested the changes in another devices.
  • Tested in iOS.
  • Tested in Android.

[ncontinanza]

LGTM! Tested in Android, every button worked fine.

[mFragaBA]

when testing on Unity, I'm getting this error when trying to click on the characters button (I also tried merging with main and then re-testing and still the error pops up):

Cannot load scene: Invalid scene name (empty string) and invalid build index -1
UnityEngine.SceneManagement.SceneManager:LoadScene (string)
MoreMountains.Tools.MMLoadScene:LoadScene () (at Assets/ThirdParty/TopDownEngine/ThirdParty/MoreMountains/MMTools/Tools/MMSceneLoading/Scripts/Helpers/MMLoadScene.cs:34)
UnityEngine.Events.UnityEvent:Invoke ()

The button has no scene set:

[BertovDev]

when testing on Unity, I'm getting this error when trying to click on the characters button (I also tried merging with main and then re-testing and still the error pops up):

Cannot load scene: Invalid scene name (empty string) and invalid build index -1
UnityEngine.SceneManagement.SceneManager:LoadScene (string)
MoreMountains.Tools.MMLoadScene:LoadScene () (at Assets/ThirdParty/TopDownEngine/ThirdParty/MoreMountains/MMTools/Tools/MMSceneLoading/Scripts/Helpers/MMLoadScene.cs:34)
UnityEngine.Events.UnityEvent:Invoke ()

The button has no scene set:

@mFragaBA Do you know if this happened after re-imporing the client Engine folder? I have seen the same problem but after those changes.

[mFragaBA]

when testing on Unity, I'm getting this error when trying to click on the characters button (I also tried merging with main and then re-testing and still the error pops up):

Cannot load scene: Invalid scene name (empty string) and invalid build index -1
UnityEngine.SceneManagement.SceneManager:LoadScene (string)
MoreMountains.Tools.MMLoadScene:LoadScene () (at Assets/ThirdParty/TopDownEngine/ThirdParty/MoreMountains/MMTools/Tools/MMSceneLoading/Scripts/Helpers/MMLoadScene.cs:34)
UnityEngine.Events.UnityEvent:Invoke ()

The button has no scene set:

@mFragaBA Do you know if this happened after re-imporing the client Engine folder? I have seen the same problem but after those changes.

@BertovDev what would re-importing the client Engine folder? The topdownengine folder? I did recently re-import it. However, I tried deleting the directory from client/Assets/ThirdParty and re-importing it but it was still not working. Also tried closing and re-opening unity but to no avail.

Talked to the team and it is actually working fine. I'll help you fix this but the team needs this fix so this dismiss was requested.