[GH-1197] get ids from gamePlayers instead of simple counter #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mFragaBA
changed the title
mFragaBA
requested review from
jrchatruc,
AminArria,
manucamejo,
tvillegas98,
fkrause98,
martinacantaro,
mgrunwaldt,
AngieDutra,
BertovDev,
ncontinanza,
saugon and
marco-paulucci
as code owners
BertovDev
approved these changes
Nov 30, 2023
BertovDev
deleted the
fix-prefab-generation-for-players-with-different-ids
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1197
Motivation
Can't test load tests while playing a game on unity (if my client gets matched with the load test's clients)
Summary of changes
How has this been tested?
Tested locally by starting a new game and quickly running a round of the load test (I mention the steps on the issue)
Test additions / changes
List tests added/updated.
Checklist