-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-1617] Unstable connection icon #1741
Conversation
This reverts commit 033590e.
Looks great! Visual approval ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing it as a user, I founded it a little difficult to play before the icon is displayed. I can see that other players are hurting me but I see them as far behind me, what to you think?
https://github.com/lambdaclass/curse_of_mirra/assets/116388676/2b1f98e4-b231-4413-a9c9-74c90f080960
I'll adjust the config for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still encountering some problems as a user when playing with bad connection. As commented above I see that other players are hurting me but I am seeing them as far behind on the arena while the icon is still not showing up:
Untitled1.mov
Untitled2.mov
We started all over in #1798 |
Closes #1617
Backend PR lambdaclass/mirra_backend#619
Motivation
When we have connectivity stability we have no feedback for the user
Summary of changes
This PR:
DISCLAIMER: this doesn't support 3g testing. The issues when using 3g will be solved in a future iteration
Animation.mov
How has this been tested?
Setting for fake spikes:
toxiproxy-server
export USE_PROXY=true
and thenmake start
toxiproxy-cli toxic add -n latency -t latency -a latency=300 game_proxy
./lag_spikes.sh
In the backend repo, go to "lag_spikes.sh":
I used the following but you can alter each value to fake your own ping spikes
In the client repo:
Go to "GameServerConnectionManager.cs" and "ServerConnection.cs" and change in method "makeWebsocketUrl()"
int port = 5000;
Checklist