Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array Codegen #119

Merged
merged 11 commits into from
May 7, 2024
Merged

Array Codegen #119

merged 11 commits into from
May 7, 2024

Conversation

JulianGCalderon
Copy link
Contributor

  • Adds lowering for storing and loading with both constant index and dynamic index.
  • Adds example of array usage.
  • Test the example against the expected output.

@JulianGCalderon JulianGCalderon changed the base branch from main to array-lowering April 26, 2024 16:41
Copy link

Benchmarking factorial

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 61.28%. Comparing base (3c18e15) to head (7d96337).

Files Patch % Lines
crates/concrete_codegen_mlir/src/codegen.rs 75.00% 19 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           array-lowering     #119      +/-   ##
==================================================
+ Coverage           58.23%   61.28%   +3.04%     
==================================================
  Files                  34       34              
  Lines                4317     4388      +71     
==================================================
+ Hits                 2514     2689     +175     
+ Misses               1803     1699     -104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulianGCalderon JulianGCalderon changed the base branch from array-lowering to main April 26, 2024 19:49
@JulianGCalderon JulianGCalderon marked this pull request as ready for review April 26, 2024 19:53
@JulianGCalderon JulianGCalderon linked an issue Apr 29, 2024 that may be closed by this pull request
@igaray igaray added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 848181b May 7, 2024
5 checks passed
@edg-l edg-l deleted the array-codegen branch May 8, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array Codegen
4 participants