Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code checking skeleton #82

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Add code checking skeleton #82

merged 9 commits into from
Feb 2, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jan 19, 2024

Adds the basis to check if the code is valid, currently it checks the following:

  • Missing imports and imported symbols.
  • Types exist.
image

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 142 lines in your changes are missing coverage. Please review.

Comparison is base (68423e9) 68.75% compared to head (ffbf029) 64.19%.

Files Patch % Lines
crates/concrete_check/src/lib.rs 0.00% 103 Missing ⚠️
crates/concrete_codegen_mlir/src/codegen.rs 84.00% 20 Missing ⚠️
crates/concrete_driver/src/lib.rs 0.00% 14 Missing ⚠️
crates/concrete_ast/src/common.rs 0.00% 3 Missing ⚠️
crates/concrete_ast/src/types.rs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           add_imports      #82      +/-   ##
===============================================
- Coverage        68.75%   64.19%   -4.56%     
===============================================
  Files               28       29       +1     
  Lines             1309     1511     +202     
===============================================
+ Hits               900      970      +70     
- Misses             409      541     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l changed the title Add basic code checking Add code checking skeleton and import checker Jan 19, 2024
@edg-l edg-l marked this pull request as ready for review January 22, 2024 15:10
@edg-l edg-l changed the title Add code checking skeleton and import checker Add code checking skeleton Jan 22, 2024
juanbono
juanbono previously approved these changes Jan 22, 2024
Base automatically changed from add_imports to main January 22, 2024 19:13
@igaray igaray dismissed juanbono’s stale review January 22, 2024 19:13

The base branch was changed.

igaray
igaray previously approved these changes Jan 22, 2024
juanbono
juanbono previously approved these changes Jan 22, 2024
@igaray igaray dismissed stale reviews from juanbono and themself January 23, 2024 14:23

The merge-base changed after approval.

igaray
igaray previously approved these changes Jan 23, 2024
@edg-l edg-l dismissed igaray’s stale review January 23, 2024 14:25

The merge-base changed after approval.

igaray
igaray previously approved these changes Jan 23, 2024
@edg-l edg-l dismissed igaray’s stale review January 23, 2024 18:46

The merge-base changed after approval.

igaray
igaray previously approved these changes Jan 23, 2024
@edg-l edg-l dismissed igaray’s stale review January 23, 2024 21:14

The merge-base changed after approval.

juanbono
juanbono previously approved these changes Jan 29, 2024
@edg-l edg-l dismissed juanbono’s stale review January 29, 2024 18:26

The merge-base changed after approval.

juanbono
juanbono previously approved these changes Jan 29, 2024
@edg-l edg-l dismissed juanbono’s stale review January 29, 2024 22:00

The merge-base changed after approval.

juanbono
juanbono previously approved these changes Jan 29, 2024
Copy link
Member

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edg-l edg-l dismissed stale reviews from juanbono and jrchatruc January 29, 2024 23:09

The merge-base changed after approval.

jrchatruc
jrchatruc previously approved these changes Jan 29, 2024
juanbono
juanbono previously approved these changes Jan 31, 2024
@edg-l edg-l dismissed juanbono’s stale review January 31, 2024 15:25

The merge-base changed after approval.

juanbono
juanbono previously approved these changes Feb 2, 2024
@edg-l edg-l dismissed juanbono’s stale review February 2, 2024 14:46

The merge-base changed after approval.

@unbalancedparentheses unbalancedparentheses merged commit e8671e5 into main Feb 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants