-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make pubkey
optional for decoded_json
in keystore
in decode_str!
function
#1104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there @artemd24! Thanks for your contribution!
As part of this issue, we need to handle when the "pubkey" field isn't specified. In that case, we need to ignore the following comparison against derived_pubkey
, and set pubkey = derived_pubkey
. Also, please add unit tests to this change (you can find examples in test/unit/keystore_test.exs
).
Hello @MegaRedHand! I have actualized changes according to your comment. |
Great work @artemd24 ! There seem to be some formatting errors. Please run |
@MegaRedHand thank you for helping me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution! 😄
@all-contributors please add @artemd24 for code |
I've put up a pull request to add @artemd24! 🎉 |
Motivation
There is not need to raise exception because of cheking pub keys further
Description
Change
Map.fetch!(decoded_json, "pubkey") |> parse_binary!()
to+some tests added
Resolves #1084
Closes #1084